Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lockable plans #580

Merged
merged 12 commits into from
Feb 22, 2025
Merged

Lockable plans #580

merged 12 commits into from
Feb 22, 2025

Conversation

bklang
Copy link
Collaborator

@bklang bklang commented Feb 17, 2025

We often have gigs that have a limited amount of space that necessitates a specific headcount. Or, other times, we have to provide a list of names to event organizers ahead of time. It can be a frustrating experience for the band leader to try to figure out who is going or not when the Gig-O attendance status (plan) changes at the last minute.

This feature adds a new button that allows band admins to lock plans on a gig. While locked, normal band members are unable to update their own status, and are shown a message explaining that they need to contact the band leaders.

Band leaders are still able to manually update plans, whether or not the gig plans are locked. This allows them to manually correct attendance.

Normal band member view:
Screenshot 2025-02-16 at 10 28 42 PM

Band admin view:
Screenshot 2025-02-16 at 10 32 31 PM

Todo:

  • Usability feedback
  • Update translations
  • Tests

@aaronoppenheimer
Copy link
Contributor

This is cool, and I think in conjunction with what's been talked about elsewhere about alerting admins about changing plans, will be really helpful.

When the gig is locked, the plan popup shouldn't look like a button - it should look like the unchangeable version. To do that, in the template gig/gig_plan_edit.html, on line 14, add to the logic something about "and not plan.gig.is_locked" or similar.

@aaronoppenheimer
Copy link
Contributor

Also - maybe the gig owner and admins can change people's responses. If it's locked to hopefully force someone to have a conversation with me about their change in plans, I should be able to change it while keeping the gig locked.

@bklang
Copy link
Collaborator Author

bklang commented Feb 22, 2025

Also - maybe the gig owner and admins can change people's responses. If it's locked to hopefully force someone to have a conversation with me about their change in plans, I should be able to change it while keeping the gig locked.

Yep, this is exactly the intent, and the current behavior. Currently it's only band admins, but I could also include the gig Contact.

@bklang
Copy link
Collaborator Author

bklang commented Feb 22, 2025

I think this is ready to go.

Non-admin members no longer see the option to change their plans when a gig is locked. On the agenda view, a lock icon appears to help explain why. They are still allowed to comment on their plans.

Screenshot 2025-02-22 at 2 13 42 PM Screenshot 2025-02-22 at 2 23 57 PM

Admin members are still able to change plans on behalf of any member.
Screenshot 2025-02-22 at 2 29 11 PM

@bklang bklang merged commit 2251e8a into main Feb 22, 2025
1 check passed
@bklang bklang deleted the lockable_plans branch February 22, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants