Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezone Updates #585

Merged
merged 10 commits into from
Feb 23, 2025
Merged

Timezone Updates #585

merged 10 commits into from
Feb 23, 2025

Conversation

aaronoppenheimer
Copy link
Contributor

Adds some fun things:

  • Autodetects a user's timezone when they look at the home page
  • Properly shows gigs on the agenda page that are in the future (or started but not ended)
  • Uses the user's timezone to add timezones to the calfeed
  • Fixes some time-validation issues on the gig edit page

This is not a fix for everything - the case where a user changes timezones but doesn't log into the gig-o is still broken since the calfeed will be using the wrong timezone.

@aaronoppenheimer
Copy link
Contributor Author

@bklang have a look!

Copy link
Collaborator

@bklang bklang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that it requires minimal from the user to be correct in most cases. If this works well, we can consider updating the timezone preferences on visits to URLs other than the base agenda route. Looks good!

@aaronoppenheimer aaronoppenheimer merged commit 80f8f14 into main Feb 23, 2025
1 check passed
@aaronoppenheimer aaronoppenheimer deleted the autoupdate_zone branch February 23, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants