-
Notifications
You must be signed in to change notification settings - Fork 22
Adding Support for User Defined Datatypes and Logical Functions #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shiva-tk
wants to merge
38
commits into
GillianPlatform:master
Choose a base branch
from
shiva-tk:shiva/user-def-datatypes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adding Support for User Defined Datatypes and Logical Functions #342
shiva-tk
wants to merge
38
commits into
GillianPlatform:master
from
shiva-tk:shiva/user-def-datatypes
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Repeating here what I said in Discord:
I think this should be fixed before merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of the type of specifications that these new features allow for can be found in
wisl/examples/SLL_adt.wisl.User Defined Datatypes
Added WISL support for user defined datatypes:
Added support for user defined datatypes in core Gillian:
Datatype_envto hold definitionsUser Defined Functions
Added WISL support for user defined functions:
Added support for user defined functions in core Gillian:
Function_envto hold definitionsNotes
General
'to differentiate it from function application in the parsing. This was mainly a quick fix, and I'm happy to take suggestions on other approaches!pure functiondenotes a logical function used in specifications, whereasfunctionrepresents a procedure.smt.mlintoengine/FOLogic/in order to avoid circular dependencies:smt.mlrequiresDatatype_env, from theenginemodule, butenginerequiressmt.ml.Datatype_envandFunction_envare mutable global references. This is for a couple of reasons. Firstly, unlike the typing environment, they aren't modified or copied or replaced during symbolic execution. They are initialised once and stay constant throughout. Secondly, it is too much of a pain to refactor every occurence ofgammato also carry around aDatatype_envand aFunction_env. There are some functions which even make gamma optional, however, the other two environments are always a necessity! I did try this approach but it proved to be too much work.SMT Encoding
Datatype_envandFunction_envare assumed to be initialised.satwhen they should have beenunsat. As a result, we add additional assertions to ensure that expressions were in-fact constructed by the constructor corresponding to the destructor.