Add demo test screnario#3191
Conversation
89851ad to
3efed65
Compare
3efed65 to
5ada1ae
Compare
asbjornu
left a comment
There was a problem hiding this comment.
Thanks for providing a test! It is, however, a bit long and hard to follow. Could you please reduce it to a minimum and explain with comments which assertions in it fail and why you expect the version to be something else that what GitVersion produces?
| // Settings the below NextVersion results in an exception | ||
| // I wanted to set it to globally start with version 1 | ||
| // Setting the version to 1.0 (which is not a valid semantic version) | ||
| // works in GitVersion.yml but not here. | ||
|
|
||
| // NextVersion = "1.0" |
There was a problem hiding this comment.
To start with a 1.0.0 version, you just need to add a git tag. You can do that in a test with fixture.Repository.MakeATaggedCommit("1.0.0").
There was a problem hiding this comment.
Making a tagged commit is a bit weird. When looking at the commit log, it looks like as if that commit was the 1.0.0 release.
That's what a version tag usually denotes (I would think)..
Also I was told, that using NextVersion in the config is a good approach here: #3123
|
The goal of this test was to describe the git workflow that I thought would be ideal and "suggested" as the default GitVersion flow. The test does exactly what I described in #3177. It's the same thing but written as a test. In this test only the last assertion fails. I think it is weird that the version on develop decrements. I will try to create another, more reduced test. |
|
I understand. Thank you for taking the time to write up such a thorough test. However, unless I've done something very strange, the test succeeds if you add the |
That's because the old test only verifies that the semantic version increments. Try it in the new test, it won't work there.
|
|
@asbjornu I have created a reduced, simplified test in |
|
@asbjornu OK I think this whole thing drills down to: |
|
It is absolutely the case that |
b7c221a to
bc3204d
Compare
4264d97 to
e78e9d2
Compare
Unfortunately tagging develop with |
|
I would suggest do continue discussion on #3177 instead of in this PR, if necessary. |
That only happens if you tag on the
I see. |
|
Did #3190 resolve this? |
|
I will only be able to test this next week - but I will. |
@asbjornu I was just trying to build the main branch locally (using Rider), and I am getting the following two errors:
What are the prerequisites to get the main branch built? |
|
@bitbonk we recently merged the .net 7 support so you should install the rc2 for now, and in couple of weeks the final release of .net 7.0 |
|
OK, running the test with the new changes yield some slightly changed behavior on how the versions ( Good job 👍🏻and thank you! Following along as the PRs progressed, it sure looked like a lot of hard work. What release will include these changes? |
|
@bitbonk the new major version - v6, but we don't have an exact time we release it, but most probably soon we'll start publishing first alphas or betas of v6 to get first feedback |
9801764 to
b7a7608
Compare
This PR is only here to demonstrate my problem described in the discussion #3177