-
Notifications
You must be signed in to change notification settings - Fork 4k
Fix headings styles in hint block #3497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 2282178 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
@clairechabas ask @zenoachtig if the heading should be full-width or not. |
@gregberge I checked our docs for this because I wasn't sure either, and it's not full-width there (see here). So it looks to be by design. |
Oh no that looks like a bug – the heading "bar" should span the complete width! |
@zenoachtig @clairechabas That's what I thought, @Claire can you fix it at the same time? |
Yep it's fixed 👍 Thanks for confirming @zenoachtig! |
The
break-words
property is set on the hint content container which works for paragraphs but doesn't work for headings because headings include 2 children: the heading text and their hash link button.Fix:
Preview
2 hints with headings of different lengths

hint heading hash button for multiple lines headings

hint heading hash button for a single line heading
