Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stable Git for Windows in test-fixtures-windows #1892

Merged
merged 2 commits into from
Mar 18, 2025
Merged

Use stable Git for Windows in test-fixtures-windows #1892

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddef6d3
Use stable Git for Windows in `test-fixtures-windows`
EliahKagan Mar 18, 2025
ee5571d
Slightly improve stylistic consistency
EliahKagan Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ jobs:
runs-on: windows-latest

steps:
- name: Upgrade Git for Windows to latest (pre)release
- name: Upgrade Git for Windows to latest stable release
# This upgrades Git to work around https://github.com/GitoxideLabs/gitoxide/issues/1849.
# TODO: Remove this step once the runner image has Git 2.49.0 or higher.
env:
Expand All @@ -203,19 +203,18 @@ jobs:
$log = 'setup-log.txt'
# Inno Setup args reference: https://jrsoftware.org/ishelp/index.php?topic=setupcmdline
$arguments = @(
'/VERYSILENT',
'/SUPPRESSMSGBOXES',
'/ALLUSERS',
"/LOG=$log",
'/NORESTART',
'/CLOSEAPPLICATIONS',
'/FORCECLOSEAPPLICATIONS'
'/VERYSILENT',
'/SUPPRESSMSGBOXES',
'/ALLUSERS',
"/LOG=$log",
'/NORESTART',
'/CLOSEAPPLICATIONS',
'/FORCECLOSEAPPLICATIONS'
)

mkdir $workingDir | Out-Null
cd $workingDir
$newestTag = gh release list --repo $repo --limit 1 --json tagName --jq '.[0].tagName'
gh release download $newestTag --repo $repo --pattern $pattern
gh release download --repo $repo --pattern $pattern
$installer = Get-Item $pattern
Start-Process -FilePath $installer -ArgumentList $arguments -NoNewWindow -Wait

Expand Down
Loading