Add missing apt-get update
in CI test
job
#1926
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI
test
job's "Setup dependencies" step hadapt-get install
without having previously runapt-get update
. This often does not work, and in a CI environment one should not typically expect it to work because package indexes in a virtual machine just provisioned from an image, if present at all, may be very outdated. But for some reason it had been working until recently, when breakages were observed, including in #1924 (though the breakage is not related to the changes in that PR).This runs
apt-get update
beforeapt-get install
in that CI job, as had already been done in the other CI jobs and as had likely always been intended. This should make the "Setup dependencies" step work again.The reason I'm doing this as a separate PR rather than by adding a commit to #1924 is that it simplifies testing the same thing both in this upstream repository and in my fork, which I think might prove valuable in case any further troubleshooting is needed. (Doing it as a separate PR probably also makes the history slightly clearer, since this change is independent of the rationale of #1924, but that's secondary.)
I plan to make sure the
test
job gets past the "Setup dependencies" step, and the enable auto-merge.