Skip to content

Conversation

cruessler
Copy link
Contributor

This is hopefully the last follow-up to #2163 and #2171. It renames the last remaining method that still had an in_place infix, gix::reference::Reference::peel_to_id_in_place_packed, so that now all in_place methods that deal with references have been deprecated.

Note that there are a few other methods that still have an in_place infix or suffix, but are not related to references, such as gix::remote::url::rewrite::Rewrite::rewrite_url_in_place.

Also, I updated a couple of doc comments that were still referring to deprecated in_place methods to refer to the new methods instead.

Also, update documentation where it was still referring to deprecated
`in_place` methods to refer to the new methods instead.
Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful, thanks a lot!

I particularly like how it removes as it's always inconsistent, and how one commit is used to change two crates, while matching well enough for both.

@Byron Byron merged commit 442f800 into GitoxideLabs:main Sep 18, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants