Remove winnow from gix-actor public API#2546
Draft
Sebastian Thiel (Byron) wants to merge 2 commits intomainfrom
Draft
Remove winnow from gix-actor public API#2546Sebastian Thiel (Byron) wants to merge 2 commits intomainfrom
winnow from gix-actor public API#2546Sebastian Thiel (Byron) wants to merge 2 commits intomainfrom
Conversation
2aab086 to
193eade
Compare
193eade to
e151dda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's too easy to not detect
winnowupdates as a breaking change, and then make patch releases that break existing builds.Tasks
winnowfromgix-actor(as breaking change) + refackiewgixas v0.83 naturally.gix-actor0.40.1 to unbreak v0.81Benches
It turns out that removing
winnowleads to a simpler but faster parser implementation, and it's probably one that I can maintain as well.