Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request to resolve issue #57 - Angular test file cli option #110

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

jackcoral89
Copy link
Contributor

@jackcoral89 jackcoral89 commented Jun 19, 2024

Added angular .spec file optional

@jackcoral89 jackcoral89 changed the base branch from main to dev June 19, 2024 13:03
@jackcoral89 jackcoral89 changed the title Issue 57 Pull request to resolve issue 57 - Angular test file cli option Jun 19, 2024
@jackcoral89 jackcoral89 changed the title Pull request to resolve issue 57 - Angular test file cli option Pull request to resolve issue #57 - Angular test file cli option Jun 19, 2024
@jackcoral89 jackcoral89 changed the base branch from dev to main June 19, 2024 13:45
Copy link
Owner

@Giuliano1993 Giuliano1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jackcoral89 first of all thx for your PR!

There's a couple of fix that needs to be addressed before I can merge this, you should see them in the review.

Briefly, at the moment, the question for a .spec file pops up also in non-angular components flow, while it shouldn't.

It also happens that for angular component the "create another component" question doesn't work anymore (it pops up but when I say yes it stops the execution anyway) , don't know if it's related to the flag fix or something else!

src/utils/wizard.mts Outdated Show resolved Hide resolved
src/utils/wizard.mts Outdated Show resolved Hide resolved
@jackcoral89
Copy link
Contributor Author

@Giuliano1993 fyi

@Giuliano1993
Copy link
Owner

Yes @jackcoral89 I saw the update thanks. I was actually thinking of the best way to proceed since I noticed that your PR is based on an outdated version of MJC, the whole project structure has changed meanwhile, so I was trying to figure out the more convenient way to move from here to include your code in the project :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants