-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull request to resolve issue #57 - Angular test file cli option #110
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jackcoral89 first of all thx for your PR!
There's a couple of fix that needs to be addressed before I can merge this, you should see them in the review.
Briefly, at the moment, the question for a .spec file pops up also in non-angular components flow, while it shouldn't.
It also happens that for angular component the "create another component" question doesn't work anymore (it pops up but when I say yes it stops the execution anyway) , don't know if it's related to the flag fix or something else!
@Giuliano1993 fyi |
Yes @jackcoral89 I saw the update thanks. I was actually thinking of the best way to proceed since I noticed that your PR is based on an outdated version of MJC, the whole project structure has changed meanwhile, so I was trying to figure out the more convenient way to move from here to include your code in the project :) |
Added angular .spec file optional