Skip to content
Open
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
132 changes: 124 additions & 8 deletions migration/1779182511001-AddIdToProjectQfRound.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,29 +4,145 @@
name = 'AddIdToProjectQfRound1779182511001';

public async up(queryRunner: QueryRunner): Promise<void> {
// Add the new id column as auto-incrementing column (not primary key)
// First, check if the table exists and get the current primary key constraint name
const tableExists = await queryRunner.hasTable(
'project_qf_rounds_qf_round',
);
if (!tableExists) {
throw new Error('Table project_qf_rounds_qf_round does not exist');
}

// Get the current primary key constraint name
const primaryKeyQuery = await queryRunner.query(`
SELECT constraint_name
FROM information_schema.table_constraints
WHERE table_name = 'project_qf_rounds_qf_round'
AND constraint_type = 'PRIMARY KEY'
`);

const primaryKeyName = primaryKeyQuery[0]?.constraint_name;

// Drop the existing composite primary key if it exists
if (primaryKeyName) {
try {
await queryRunner.query(`
ALTER TABLE "project_qf_rounds_qf_round"
DROP CONSTRAINT "${primaryKeyName}"
`);
} catch (error) {
console.log(

Check failure on line 33 in migration/1779182511001-AddIdToProjectQfRound.ts

View workflow job for this annotation

GitHub Actions / test

Unexpected console statement
`Failed to drop constraint ${primaryKeyName}, trying alternative approach...`,
);
// Try with IF EXISTS as fallback
await queryRunner.query(`
ALTER TABLE "project_qf_rounds_qf_round"
DROP CONSTRAINT IF EXISTS "${primaryKeyName}"
`);
}
} else {
// Fallback: try to drop with constraint detection
const constraintQuery = await queryRunner.query(`
SELECT conname
FROM pg_constraint
WHERE conrelid = (
SELECT oid
FROM pg_class
WHERE relname = 'project_qf_rounds_qf_round'
) AND contype = 'p'
`);

if (constraintQuery[0]?.conname) {
await queryRunner.query(`
ALTER TABLE "project_qf_rounds_qf_round"
DROP CONSTRAINT "${constraintQuery[0].conname}"
`);
}
}

// Add the new id column as auto-incrementing primary key
await queryRunner.query(`
ALTER TABLE "project_qf_rounds_qf_round"
ADD COLUMN "id" SERIAL
ADD COLUMN "id" SERIAL PRIMARY KEY
`);

// Add index on the id column for performance
// Add unique constraint on the composite key to maintain uniqueness
await queryRunner.query(`
CREATE INDEX "IDX_project_qf_rounds_id"
ON "project_qf_rounds_qf_round" ("id")
ALTER TABLE IF EXISTS "project_qf_rounds_qf_round"
ADD CONSTRAINT "UQ_project_qf_rounds_composite"
UNIQUE ("projectId", "qfRoundId")
`);

// Add indexes on projectId and qfRoundId for performance
await queryRunner.query(`
CREATE INDEX "IDX_project_qf_rounds_projectId"
ON "project_qf_rounds_qf_round" ("projectId")
`);

await queryRunner.query(`
CREATE INDEX "IDX_project_qf_rounds_qfRoundId"
ON "project_qf_rounds_qf_round" ("qfRoundId")
`);
}

public async down(queryRunner: QueryRunner): Promise<void> {
// Drop the index first
// Drop the indexes first
await queryRunner.query(`
DROP INDEX IF EXISTS "IDX_project_qf_rounds_projectId"
`);

await queryRunner.query(`
DROP INDEX IF EXISTS "IDX_project_qf_rounds_id"
DROP INDEX IF EXISTS "IDX_project_qf_rounds_qfRoundId"
`);

// Drop the unique constraint
await queryRunner.query(`
ALTER TABLE IF EXISTS "project_qf_rounds_qf_round"
DROP CONSTRAINT IF EXISTS "UQ_project_qf_rounds_composite"
`);

// Get the current primary key constraint name for the id column
const primaryKeyQuery = await queryRunner.query(`
SELECT constraint_name
FROM information_schema.table_constraints
WHERE table_name = 'project_qf_rounds_qf_round'
AND constraint_type = 'PRIMARY KEY'
`);

const primaryKeyName = primaryKeyQuery[0]?.constraint_name;

if (primaryKeyName) {
try {
// Drop the id primary key constraint
await queryRunner.query(`
ALTER TABLE "project_qf_rounds_qf_round"
DROP CONSTRAINT "${primaryKeyName}"
`);
} catch (error) {
// Fallback with IF EXISTS
await queryRunner.query(`
ALTER TABLE "project_qf_rounds_qf_round"
DROP CONSTRAINT IF EXISTS "${primaryKeyName}"
`);
}
} else {
// Fallback: drop all possible primary key constraints
await queryRunner.query(`
ALTER TABLE "project_qf_rounds_qf_round"
DROP CONSTRAINT IF EXISTS "UQ_project_qf_rounds_qf_round"
`);
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.

// Drop the id column
await queryRunner.query(`
ALTER TABLE "project_qf_rounds_qf_round"
ALTER TABLE IF EXISTS "project_qf_rounds_qf_round"
DROP COLUMN IF EXISTS "id"
`);

// Restore the composite primary key
await queryRunner.query(`
ALTER TABLE IF EXISTS "project_qf_rounds_qf_round"
ADD CONSTRAINT "PK_project_qf_rounds_qf_round"
PRIMARY KEY ("projectId", "qfRoundId")
`);
Comment on lines +293 to +298
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Hard-coded constraint name may differ from original.

The composite primary key is restored with the hard-coded name "PK_project_qf_rounds_qf_round" (line 296), but the original constraint may have had a different name (e.g., "PK_046d515dee2988817725ec75ebf" as seen in line 52).

This was previously flagged and marked as addressed in commit 6595f6d, but the hard-coded name remains.

While functionally equivalent, this creates a naming inconsistency. Consider dynamically determining the original name if perfect reversibility is required. However, since constraint names don't affect behavior, this may be acceptable if you're standardizing on the new name going forward.

If standardization is not the goal, you could store the original PK name before dropping it in up() and reference it in down():

// In up(), before dropping PKs:
const originalPK = await queryRunner.query(`
  SELECT conname 
  FROM pg_constraint 
  WHERE conrelid = 'project_qf_rounds_qf_round'::regclass 
  AND contype = 'p' 
  LIMIT 1
`);
// Store originalPK[0]?.conname somewhere (e.g., migration metadata table)

// In down():
// Retrieve stored name and use it instead of hard-coded value
🤖 Prompt for AI Agents
In migration/1779182511001-AddIdToProjectQfRound.ts around lines 293-298 the
composite PK is recreated with a hard-coded name
"PK_project_qf_rounds_qf_round", which may differ from the original and breaks
perfect reversibility; before dropping the original PK in up(), query
pg_constraint for the existing primary key name on project_qf_rounds_qf_round
and persist that name (e.g., in a simple migration metadata table or a temporary
table/comment), then in down() retrieve and use that persisted name when
re-adding the constraint instead of the hard-coded string so the original
constraint name is restored; alternatively, if you intend to standardize on the
new name, document that decision and leave the new name.

}
}
13 changes: 8 additions & 5 deletions src/entities/projectQfRound.ts
Original file line number Diff line number Diff line change
@@ -1,31 +1,34 @@
import { Field, ID, ObjectType, Float, Int } from 'type-graphql';
import {
PrimaryColumn,
PrimaryGeneratedColumn,
Column,
Entity,
ManyToOne,
BaseEntity,
CreateDateColumn,
UpdateDateColumn,
Index,
Unique,
} from 'typeorm';
import { Project } from './project';
import { QfRound } from './qfRound';

@Entity('project_qf_rounds_qf_round')
@ObjectType()
@Unique(['projectId', 'qfRoundId']) // Ensure uniqueness of the composite key
export class ProjectQfRound extends BaseEntity {
@Field(_type => ID)
@Column({ generated: 'increment' })
@Index()
@PrimaryGeneratedColumn() // Make this the primary key
id: number;

@Field(_type => ID)
@PrimaryColumn()
@Column()
@Index()
projectId: number;

@Field(_type => ID)
@PrimaryColumn()
@Column()
@Index()
qfRoundId: number;

@ManyToOne(_type => Project, project => project.projectQfRoundRelations)
Expand Down
Loading