Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed threshold not clickable in scene trigger on device change #1941

Merged

Conversation

William-De71
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

PR to fix threshold not clickable on scene trigger
#1940

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (440fbe9) 98.17% compared to head (e2ccacd) 98.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1941   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files         776      776           
  Lines       12167    12167           
=======================================
  Hits        11945    11945           
  Misses        222      222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Nov 21, 2023

Job #2058: Bundle Size — 9.01MiB (~-0.01%).

e2ccacd(current) vs 440fbe9 master#2053(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
Job #2058
     Baseline
Job #2053
Improvement  Initial JS 4.86MiB(~-0.01%) 4.86MiB
No change  Initial CSS 302.38KiB 302.38KiB
Change  Cache Invalidation 53.8% 0%
No change  Chunks 51 51
No change  Assets 157 157
No change  Modules 1400 1400
No change  Duplicate Modules 20 20
No change  Duplicate Code 0.83% 0.83%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
Job #2058
     Baseline
Job #2053
Improvement  JS 6.52MiB (~-0.01%) 6.52MiB
Not changed  IMG 2.06MiB 2.06MiB
Not changed  CSS 318.76KiB 318.76KiB
Not changed  Fonts 93.55KiB 93.55KiB
Not changed  Other 16.06KiB 16.06KiB
Not changed  HTML 13.58KiB 13.58KiB

View job #2058 reportView William-De71:scene-trigger-thres... branch activity

@Pierre-Gilles Pierre-Gilles merged commit ae8c747 into GladysAssistant:master Nov 22, 2023
@William-De71 William-De71 deleted the scene-trigger-threshold branch November 28, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants