Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: tooltip bug when unchecking a curve on multi-charts #2199

Closed
wants to merge 2 commits into from
Closed

Fix: tooltip bug when unchecking a curve on multi-charts #2199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4a0f23
Refactor chart options to handle very low values and NaN
Terdious Jan 20, 2025
d2edcfa
Merge branch 'master' into fixed-tooltip-bug-when-unchecking-a-curve-…
Terdious Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion front/src/components/boxs/chart/ApexChartAreaOptions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,10 @@
yaxis: {
labels: {
padding: 4,
formatter: function(value) {

Check warning on line 55 in front/src/components/boxs/chart/ApexChartAreaOptions.js

View workflow job for this annotation

GitHub Actions / Front test 

Expected method shorthand
if (Math.abs(value) < 1) {
if (Math.abs(value) < 1 || isNaN(value)) {
return value; // For very low values, like crypto prices, use the normal value
} else {

Check warning on line 58 in front/src/components/boxs/chart/ApexChartAreaOptions.js

View workflow job for this annotation

GitHub Actions / Front test 

Unnecessary 'else' after 'return'
return value.toFixed(2); // 2 decimal places for other values
}
}
Expand Down
2 changes: 1 addition & 1 deletion front/src/components/boxs/chart/ApexChartBarOptions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,10 @@
yaxis: {
labels: {
padding: 4,
formatter: function(value) {

Check warning on line 63 in front/src/components/boxs/chart/ApexChartBarOptions.js

View workflow job for this annotation

GitHub Actions / Front test 

Expected method shorthand
if (Math.abs(value) < 1) {
if (Math.abs(value) < 1 || isNaN(value)) {
return value; // For very low values, like crypto prices, use the normal value
} else {

Check warning on line 66 in front/src/components/boxs/chart/ApexChartBarOptions.js

View workflow job for this annotation

GitHub Actions / Front test 

Unnecessary 'else' after 'return'
return value.toFixed(2); // 2 decimal places for other values
}
}
Expand Down
2 changes: 1 addition & 1 deletion front/src/components/boxs/chart/ApexChartLineOptions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ const getApexChartLineOptions = ({ height, displayAxes, series, colors, locales,
labels: {
padding: 4,
formatter: function(value) {
if (Math.abs(value) < 1) {
if (Math.abs(value) < 1 || isNaN(value)) {
return value; // For very low values, like crypto prices, use the normal value
} else {
return value.toFixed(2); // 2 decimal places for other values
Expand Down
2 changes: 1 addition & 1 deletion front/src/components/boxs/chart/ApexChartStepLineOptions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ const getApexChartStepLineOptions = ({ height, displayAxes, series, colors, loca
labels: {
padding: 4,
formatter: function(value) {
if (Math.abs(value) < 1) {
if (Math.abs(value) < 1 || isNaN(value)) {
return value; // For very low values, like crypto prices, use the normal value
} else {
return value.toFixed(2); // 2 decimal places for other values
Expand Down
Loading