Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart: Rollback smart rounding of values, only keep small number part #2216

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Jan 31, 2025

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.

Description of change

Smart rounding doesn't work: https://community.gladysassistant.com/t/arrondi-des-ordonnees-sur-les-graphiques/9289/16?u=pierre-gilles

Copy link

Deploying gladys-plus with  Cloudflare Pages  Cloudflare Pages

Latest commit: ceba597
Status: ✅  Deploy successful!
Preview URL: https://8cb92a6e.gladys-plus.pages.dev
Branch Preview URL: https://fix-round-apex.gladys-plus.pages.dev

View logs

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.54%. Comparing base (c56d552) to head (ceba597).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2216   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files         876      876           
  Lines       14455    14455           
=======================================
  Hits        14244    14244           
  Misses        211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Jan 31, 2025

#2991 Bundle Size — 10.42MiB (~-0.01%).

ceba597(current) vs c56d552 master#2983(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
#2991
     Baseline
#2983
Improvement  Initial JS 5.65MiB(~-0.01%) 5.65MiB
No change  Initial CSS 304.87KiB 304.87KiB
Change  Cache Invalidation 54.1% 56.96%
No change  Chunks 51 51
No change  Assets 173 173
No change  Modules 1512 1512
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.83% 0.83%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 6 changes Regression 6 regressions
                 Current
#2991
     Baseline
#2983
Regression  JS 7.44MiB (+100%) undefined
Regression  IMG 2.54MiB (+100%) undefined
Regression  CSS 321.77KiB (+100%) undefined
Regression  Fonts 93.55KiB (+100%) undefined
Regression  Other 17.79KiB (+100%) undefined
Regression  HTML 13.58KiB (+100%) undefined

Bundle analysis reportBranch fix-round-apexProject dashboard


Generated by RelativeCIDocumentationReport issue

@Pierre-Gilles Pierre-Gilles merged commit f947056 into master Jan 31, 2025
10 checks passed
@Pierre-Gilles Pierre-Gilles deleted the fix-round-apex branch January 31, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant