Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicated files in folder content and contentFiles #658

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

cyanial
Copy link

@cyanial cyanial commented Jun 21, 2024

https://stackoverflow.com/questions/47468941/prevent-duplicating-files-in-nuget-content-and-contentfiles-folders

Test NuGetPackage: MongoDB.Libmongocrypt.

as far as i know, that a nuget package may have both content and contentFiles folder and the contain the same files.

from now on, i change the code to omit content folder when it has contentFiles and it works for my package.

And it fix my isuue #655

@JoC0de @GlitchEnzo ; Please help!!!

@JoC0de
Copy link
Collaborator

JoC0de commented Jul 21, 2024

Sorry for the delay.
Thanks for the workaround.
Would be nice if we add a UnitTest, I could implement it but not sure when I have time.

@cyanial
Copy link
Author

cyanial commented Jul 22, 2024

Sorry for the delay. Thanks for the workaround. Would be nice if we add a UnitTest, I could implement it but not sure when I have time.

never mind, i'm now using my own version, it works.

And i'm studying this project as well, i'm also trying to add some unit test. but i'm a new starter in C#, so forgive for my poor c# skills.

@cyanial cyanial requested a review from JoC0de July 22, 2024 06:42
Copy link
Author

@cyanial cyanial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants