Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add special handeling of too long path's #692

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

JoC0de
Copy link
Collaborator

@JoC0de JoC0de commented Jan 5, 2025

fixes #688

@JoC0de JoC0de self-assigned this Jan 5, 2025
Copy link
Collaborator

@igor84 igor84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still can hit the problem but I guess it reduced a chance for it a bit.

@JoC0de
Copy link
Collaborator Author

JoC0de commented Jan 6, 2025

@igor84 The only problem I see is that it will not produce consistent results on different machines when someone places the same Unity project in a "longer" path and gets e.g. the issue that a DLL is not found beaus it doesn't have the same name. To really solve the inconsistency we would need a setting that forces the path shortening. Eventually we can make the whole Path shortening optional so the user knows that it happens but probably the potential issues will occur when the user forgot that he enabled it. But I think all of this is relay an edge case.

@JoC0de JoC0de merged commit 5764d44 into GlitchEnzo:master Jan 14, 2025
8 checks passed
@JoC0de JoC0de deleted the feature/shorten-target-file-path branch January 14, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to install packages with long names
2 participants