Add set(document_id: String, data: Dictionary) function #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
good idea |
|
Looks right. I'll have to pull it down to test and am still waking up, but cool! |
WolfgangSenff
requested changes
Mar 8, 2025
There was a problem hiding this comment.
I hate to ask, but could you change the name of the function to set_doc? The reason is that set itself is likely to be the name of a function from Godot itself and I want to keep it future proof against likely problems. I haven't pulled it down yet, but I actually thought this would already fail to run because of that issue - just get fails because of it.
|
Sorry for late reply |
WolfgangSenff
approved these changes
Mar 29, 2025
|
Nice work, congrats on your first big contribution! And thank you for helping out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add set(document_id: String, data: Dictionary) function in firestore_collection.gd to replace a document by a Dictionary