using list and join function #123
Conversation
|
please accept this PR under hacktober-accpeted tag! |
There was a problem hiding this comment.
Hello, @Faizan96322!
I've reviewed your PR and I've left appropriate comments for each file that you've submitted.
Please make the appropriate changes and I'll merge this in.
Thank you for your submission.
| try: | ||
| raise Exception("Hello, World!") | ||
| except Exception as e: | ||
| print(str(e)) |
There was a problem hiding this comment.
There is an existing implementation for this solution that you've submitted!
You can find the existing solution here. The concept is the same (to use exceptions) so I'll be needing you to remove this submission from your PR.
| words = ["Hello", "World"] | ||
|
|
||
| message = " ".join(words) | ||
| print(message) |
There was a problem hiding this comment.
There is an existing implementation for this solution that you've submitted!
You can find the existing solution here. Using the .join() method to join the elements of a list has been already implemented. I'll need you to remove this implementation from this PR as well.
| from googletrans import Translator | ||
| text = 'Hola Mundo!' | ||
| translator = Translator() | ||
| print(translator.translate(text).text) |
There was a problem hiding this comment.
This is a nice implementation! I'll be accepting this PR for this solution after we've made a couple of changes to it.
Here's the list of changes I want you to make:
- Can you add the version of the
googletranslibrary as a comment? So that users can know what version ofgoogletransto use while running this program. - I need you to add an empty line at the end of this file.
Kindly implement these changes and I'll be happy to merge this PR in.
No description provided.