Skip to content

Error messages fix #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kittu wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Error messages fix #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cedf7df
Use errorExplanation for id and class name for errors block
chiragsinghal Feb 16, 2022
bdb281b
Enumerable#sum is deprecated in Rails 7.1
kittu Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/action_view/helpers/dynamic_form.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,8 @@ def error_message_on(object, method, *args)
# This <tt>DIV</tt> can be tailored by the following options:
#
# * <tt>:header_tag</tt> - Used for the header of the error div (default: "h2").
# * <tt>:id</tt> - The id of the error div (default: "error_explanation").
# * <tt>:class</tt> - The class of the error div (default: "error_explanation").
# * <tt>:id</tt> - The id of the error div (default: "errorExplanation").
# * <tt>:class</tt> - The class of the error div (default: "errorExplanation").
# * <tt>:object</tt> - The object (or array of objects) for which to display errors,
# if you need to escape the instance variable convention.
# * <tt>:object_name</tt> - The object name to use in the header, or any text that you prefer.
Expand Down Expand Up @@ -207,7 +207,7 @@ def error_messages_for(*params)
value = options[key]
html[key] = value unless value.blank?
else
html[key] = 'error_explanation'
html[key] = 'errorExplanation'
end
end
options[:object_name] ||= params.first
Expand All @@ -221,7 +221,7 @@ def error_messages_for(*params)

message = options.include?(:message) ? options[:message] : locale.t(:body)

error_messages = objects.sum do |object|
error_messages = objects.map do |object|
object.errors.full_messages.map do |msg|
content_tag(:li, msg)
end
Expand Down