-
Notifications
You must be signed in to change notification settings - Fork 74
Add guide and evals for state-aware sticky headers #603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
388701f
Add guide and evals for context-sensitive sticky headers with hardene…
patrickkettner 284c80d
rm eval files
rviscomi 43ccd38
Fix eval tests and finalize state-aware sticky headers
patrickkettner 55a3112
Merge branch 'main' into sticky-headers-guide
patrickkettner cc616a8
updates from review
patrickkettner 2355bd2
Update guides/user-experience/state-aware-sticky-headers/guide.md
patrickkettner c86edf4
narrow overflow-anchor scope to sticky parent per review
patrickkettner 5ab7837
Update guides/user-experience/state-aware-sticky-headers/guide.md
patrickkettner 8eaaaa1
Merge remote-tracking branch 'origin/main' into sticky-headers-guide
rviscomi 20334d4
address lea's review
patrickkettner b333a53
Merge remote-tracking branch 'origin/main' into sticky-headers-guide
patrickkettner 0dfe117
tighten the new grader check
patrickkettner 5c1e5cd
Merge origin/main into sticky-headers-guide
rviscomi 9a48eca
Move state-aware-sticky-headers to ui-atoms and update CODEOWNERS
rviscomi edf49b5
Auto-generate README.md for state-aware-sticky-headers
rviscomi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file was deleted.
Oops, something went wrong.
71 changes: 54 additions & 17 deletions
71
...ontext-sensitive-sticky-headers/demo.html → ...toms/state-aware-sticky-headers/demo.html
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| - The header container uses `position: sticky` to remain at the top of the scroller. | ||
| - If any of the stuck styles change layout, `overflow-anchor: none` is applied to the parent of the header container. | ||
| - If none of the stuck styles change layout, `overflow-anchor: none` should NOT be applied to the parent of the header container. | ||
| - The header container defines `container-type: scroll-state` to enable scroll state queries. | ||
| - The header container defines `container-name: section-header` to avoid collisions. | ||
| - The header visual style changes (e.g., background color or box-shadow) when it is stuck at the top. | ||
|
patrickkettner marked this conversation as resolved.
|
||
| - The visual style changes are implemented using the `@container scroll-state(stuck: top)` query. | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.