Dedupe popover fallback guidance#967
Open
LeaVerou wants to merge 3 commits into
Open
Conversation
Multiple guides independently repeated the same Popover-API fallback advice (the @oddbird/popover-polyfill recommendation with feature detection, the :popover-open styling caveat, and the position: fixed no-polyfill fallback). Consolidate it once in features/popover.md's Fallbacks section and replace the duplicated prose in each guide with FEATURE_FALLBACKS, which also prepends the live Baseline status. Per-feature fallbacks for other features (anchor positioning, interest invokers, invoker commands, popover-hint) are left in place. navigation-drawer is not converted: it has bespoke component-specific popover guidance (popover="manual", drop popover entirely rather than polyfill), so its redundant top-level macro call is removed instead.
LeaVerou
requested review from
malchata,
micahjo7,
paulirish,
philipwalton and
rviscomi
as code owners
jamesnw
approved these changes
Jun 25, 2026
Co-authored-by: James Stuckey Weber <jamesnw@gmail.com>
Co-authored-by: James Stuckey Weber <jamesnw@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple guides independently repeated the same Popover-API fallback advice (the @oddbird/popover-polyfill recommendation with feature detection, the :popover-open styling caveat, the position: fixed no-polyfill fallback, etc).
Consolidate it once in
features/popover.md's Fallbacks section and replace the duplicated prose in each guide with the FEATURE_FALLBACKS, which also prepends the live Baseline status.navigation-drawer is not converted: it has bespoke component-specific popover guidance (popover="manual", drop popover entirely rather than polyfill), so its redundant top-level macro call is removed instead.