feat: Add ListBaselineStatusCounts to retrieve cumulative baseline feature counts in spanner #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcscottiii
force-pushed
the
jcscottiii/baseline_count
branch
from
f1fe76e to
89fe016
Compare
|
I just realized something is a little off with my tests. Converting to draft for now. Sorry about that. |
jcscottiii
force-pushed
the
jcscottiii/baseline_count
branch
from
89fe016 to
6ec6807
Compare
|
@DanielRyanSmith @jrobbins This is ready now. |
…ture counts This PR introduces the `ListBaselineStatusCount` function and its associated helper functions to retrieve a cumulative count of baseline features over time. The `ListBaselineStatusCount` function works similarly to `ListBrowserFeatureCountMetric` by: 1. Calculating an initial cumulative count of baseline features up to the specified `startAt` date. 2. Retrieving subsequent baseline feature counts within the specified date range (`startAt` to `endAt`). 3. Accumulating these counts to provide a cumulative view of baseline feature adoption over time. Currently, the function only supports retrieving counts based on the `LowDate` field in the `FeatureBaselineStatus` table. However, support for `HighDate` can be easily added in the future by expanding the `BaselineDateType` enum and updating the query construction logic. This functionality is useful for tracking the overall adoption of baseline features and understanding how the baseline status of features changes over time.
jcscottiii
force-pushed
the
jcscottiii/baseline_count
branch
from
6ec6807 to
c344a7d
Compare
jcscottiii
changed the title
DanielRyanSmith
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is from today's discussion with @atopal. (There will be more parts to add the API and frontend parts into the global feature support chart)
This PR introduces the
ListBaselineStatusCountsfunction and its associated helper functions to retrieve a cumulative count of baseline features over time.The
ListBaselineStatusCountsfunction works similarly toListBrowserFeatureCountMetricby:startAtdate.startAttoendAt).Currently, the function only supports retrieving counts based on the
LowDatefield in theFeatureBaselineStatustable. However, support forHighDatecan be easily added in the future by expanding theBaselineDateTypeenum and updating the query construction logic.This functionality is useful for tracking the overall adoption of baseline features and understanding how the baseline status of features changes over time.