updated MongoDB connectivity using Private service connect#4057
updated MongoDB connectivity using Private service connect#4057theshanbhag wants to merge 1 commit into
Conversation
| gcp_project_id = var.project_id | ||
|
|
||
| # Wait for the GCP PSC forwarding rule before registering it in Atlas. | ||
| depends_on = [module.addresses] |
There was a problem hiding this comment.
this depends_on is unnecessary and redundant.
| from = mongodbatlas_cluster.default | ||
| to = mongodbatlas_advanced_cluster.default |
There was a problem hiding this comment.
Using moved blocks between different resource types requires explicit support from the provider. Does the mongodbatlas support this?
Automated PR Review 🤖(Reviewed commit: 989553c) Thank you for your pull request! Here is a review of the changes. PR TitleThe PR title currently does not follow the repository conventions. It should be short, capitalized, imperative, and have no trailing dot (e.g., no Conventional Commits prefixes). Code ReviewThe changes to the MongoDB Atlas resources and the PSC address configuration look solid. I only have one minor formatting note:
Once the PR title and the missing newline are addressed, a maintainer will do the final review and approval. Thanks again for your contribution! |
MongoDB's legacy implementation for Private service connect required 50 service attachments; With latest changes we can create the same using one load balancer.
Checklist
I applicable, I acknowledge that I have:
terraform fmton all modified filestools/tfdoc.py