Skip to content

updated MongoDB connectivity using Private service connect#4057

Open
theshanbhag wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
theshanbhag:mongodb/mongodb-private-service-connect-update
Open

updated MongoDB connectivity using Private service connect#4057
theshanbhag wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
theshanbhag:mongodb/mongodb-private-service-connect-update

Conversation

@theshanbhag

Copy link
Copy Markdown

MongoDB's legacy implementation for Private service connect required 50 service attachments; With latest changes we can create the same using one load balancer.

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

gcp_project_id = var.project_id

# Wait for the GCP PSC forwarding rule before registering it in Atlas.
depends_on = [module.addresses]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this depends_on is unnecessary and redundant.

Comment on lines +73 to +74
from = mongodbatlas_cluster.default
to = mongodbatlas_advanced_cluster.default

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using moved blocks between different resource types requires explicit support from the provider. Does the mongodbatlas support this?

@github-actions

Copy link
Copy Markdown

Automated PR Review 🤖

(Reviewed commit: 989553c)

Thank you for your pull request! Here is a review of the changes.

PR Title

The PR title currently does not follow the repository conventions. It should be short, capitalized, imperative, and have no trailing dot (e.g., no Conventional Commits prefixes).
Please update the title to something like:
Update MongoDB connectivity using Private Service Connect

Code Review

The changes to the MongoDB Atlas resources and the PSC address configuration look solid. I only have one minor formatting note:

fast/project-templates/data-mongodb/main.tf

  • There is a missing newline at the end of the file. Please ensure the file ends with a newline character to comply with standard POSIX file formatting and Terraform linting rules.

Once the PR title and the missing newline are addressed, a maintainer will do the final review and approval. Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants