Skip to content

Conversation

lachlan-roberts
Copy link

This is based on the work from #235.

Port the invoker to upgrade to Eclipse Jetty-12 version 12. Specifically using the new core APIs of Eclipse Jetty-12 that allow the overhead of a Servlet container to be avoided.

BREAKING CHANGE: use Java 17 or above, as required by Eclipse Jetty-12.

Replaces

Port the invoker to upgrade to Eclipse Jetty-12 version 12.  Specifically using the new core APIs of Eclipse Jetty-12 that allow the overhead of a Servlet container to be avoided.

BREAKING CHANGE: use Java 17 or above, as required by Eclipse Jetty-12.

Signed-off-by: Lachlan Roberts <[email protected]>
Port the invoker to upgrade to Eclipse Jetty-12 version 12.  Specifically using the new core APIs of Eclipse Jetty-12 that allow the overhead of a Servlet container to be avoided.

BREAKING CHANGE: use Java 17 or above, as required by Eclipse Jetty-12.

Signed-off-by: Lachlan Roberts <[email protected]>
@lachlan-roberts lachlan-roberts changed the title use Jetty-12.1 core without servlets chore(implementation): use Jetty-12 core without servlets Sep 30, 2025
@lachlan-roberts lachlan-roberts changed the title chore(implementation): use Jetty-12 core without servlets chore(implementation): use Jetty-12.1 core without servlets Sep 30, 2025
@ludoch
Copy link
Collaborator

ludoch commented Oct 3, 2025

Thanks!
We need to remove jdk11 constraints in builds. I guess only a Googler can understand and change the kokoro files to jdk17

Also all references with maven.compiler.source>11</maven.compiler.source> need to change to 17

@ludoch ludoch requested a review from akerekes October 3, 2025 18:02
@ludoch
Copy link
Collaborator

ludoch commented Oct 3, 2025

@akerekes please help on google internal kokoro workflows.
The entire new code now has to only work with java17,21 and 25, so drop 11 and add new configs.

@ludoch ludoch self-requested a review October 3, 2025 18:04
@akerekes
Copy link
Contributor

akerekes commented Oct 3, 2025

Hi @lachlan-roberts , thank you for the PR! I'll work on the Google internal side. One note on the timeline is that Cloud Function deprecates java11 at the end of the month: https://cloud.google.com/functions/docs/runtime-support#java so my preference is to have this PR ready to merge, but wait until the end of the month with the merge, then do it in early November and release a new version of the FF-java library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants