fix(exclude regex tests): Correction for only dir tests flags for exclude regex test

[PranjalC100]

Description

This PR fixes a configuration gap in the integration test TestCacheFileForExcludeRegexTest.

Currently, when running tests with OnlyDirMounted (mounting a specific directory rather than the root bucket), the --enable-kernel-reader=false flag is not passed to GCSFuse. This flag is required to ensure consistent behavior with other read cache tests and to prevent test flakiness related to kernel readahead interacting with the test's cache validation logic.

Changes

• Updated tools/integration_tests/read_cache/cache_file_for_exclude_regex_test.go to include --enable-kernel-reader=false in the flag set for directory mounts.

Link to the issue in case of a bug fix.

https://buganizer.corp.google.com/issues/480942316

Testing details

1. Manual - Done
2. Unit tests - NA
3. Integration tests - NA

Any backward incompatible change? If so, please explain.

[gemini-code-assist]

Summary of Changes

Hello @PranjalC100, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue within an integration test for GCSFuse's read cache functionality. It ensures that a critical flag, --enable-kernel-reader=false, is consistently applied during specific test scenarios involving directory mounts. This adjustment is designed to enhance the reliability of the test suite by preventing unpredictable behavior caused by kernel-level read-ahead mechanisms, leading to more stable and accurate test results.

Highlights

• Test Configuration Fix: Corrected a configuration gap in the TestCacheFileForExcludeRegexTest integration test.
• Kernel Reader Flag: Ensured the --enable-kernel-reader=false flag is passed to GCSFuse when running tests with OnlyDirMounted.
• Test Stability: Improved test consistency and prevented flakiness by addressing interactions with kernel readahead.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly adds the --enable-kernel-reader=false flag to the TestCacheFileForExcludeRegexTest integration test for OnlyDirMounted scenarios, which should resolve the test flakiness issue.

I've also suggested a small refactoring to reduce code duplication in the flag definitions, which will improve maintainability.

[vipnydav]

LGTM. Did you test it out manually that before this change we were not getting --enable-kernel-reader=false in the flags for only-dir mounts and after this change we started getting the flag and the test passes?

If so, update the Manual Testing to Done.

[PranjalC100]

LGTM. Did you test it out manually that before this change we were not getting --enable-kernel-reader=false in the flags for only-dir mounts and after this change we started getting the flag and the test passes?

If so, update the Manual Testing to Done.

Yes I've verified the same!

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (4d43784) to head (9f66251).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #4335       +/-   ##
==========================================
- Coverage   83.66%       0   -83.67%     
==========================================
  Files         161       0      -161     
  Lines       19472       0    -19472     
==========================================
- Hits        16292       0    -16292     
+ Misses       2579       0     -2579     
+ Partials      601       0      -601     

Flag	Coverage Δ
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.