test(integration): align Pirlo integration test behavior with Zonal buckets when rapid writes are enabled - #4913
test(integration): align Pirlo integration test behavior with Zonal buckets when rapid writes are enabled#4913vipnydav wants to merge 47 commits into
Conversation
c1cf6f5 to
f539f41
Compare
There was a problem hiding this comment.
Code Review
This pull request integrates support and test coverage for Pirlo buckets and rapid writes across various integration tests. It refactors several test files to use test suites, allowing tests to run under both base and rapid-write-enabled configurations. Additionally, it updates test_config.yaml to specify these new flag combinations and disables GKE runs for several tests. A review comment highlights a loss of test coverage in TestStaleHandleStreamingWritesEnabled due to the consolidation of Pirlo bucket flag sets, suggesting that both enable-rapid-writes=true and enable-rapid-writes=false scenarios should continue to be explicitly tested.
I am having trouble creating individual review comments. Click here to see my feedback.
tools/integration_tests/test_config.yaml (779)
The test configurations for Pirlo buckets in TestStaleHandleStreamingWritesEnabled have been consolidated into a single flag set that omits the --enable-rapid-writes flag. This means the test will only run with the default value (false), and the explicit test case for enable-rapid-writes=true is lost. To ensure both scenarios are tested, you should restore the two separate flag sets for enable-rapid-writes=true and enable-rapid-writes=false.
- "--experimental-enable-pirlo,--enable-rapid-writes=true,--metadata-cache-ttl-secs=0,--write-block-size-mb=1,--write-max-blocks-per-file=1"
- "--experimental-enable-pirlo,--enable-rapid-writes=false,--metadata-cache-ttl-secs=0,--write-block-size-mb=1,--write-max-blocks-per-file=1"c35b5ef to
a006806
Compare
a1a9d74 to
d753cf1
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4913 +/- ##
===========================================
+ Coverage 0 83.83% +83.83%
===========================================
Files 0 174 +174
Lines 0 21380 +21380
===========================================
+ Hits 0 17924 +17924
- Misses 0 2776 +2776
- Partials 0 680 +680
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…n test_config.yaml
…test suites in test_config.yaml
8d11a35 to
d9a7272
Compare
…check Pirlo bucket run in WaitForSizeUpdate
96c1740 to
f7261d4
Compare
… WriteChunkOfRandomBytesToFiles
…teToFileSequentially
…n streaming_writes and stale_handle tests
Description
When rapid writes are enabled for Pirlo (RCU) buckets (
--experimental-enable-pirlo --enable-rapid-writes=true), open files and appends create unfinalized objects on GCS prior to file flush or close, following the exact behavior of Zonal (RAPID) buckets.This PR updates GCSFuse integration tests to handle Pirlo buckets with rapid writes enabled identically to Zonal buckets:
WaitDurationAfterFlushRapidandWaitDurationAfterCloseRapid) to ensure tests wait appropriately for unfinalized object size and metadata propagation after file flushes and handle closes.test_config.yaml) to define Pirlo flag sets withrun_on_gke: falseand appropriate test selection (run:/skip:).require.NoErrorandassert.NoError.Link to the issue in case of a bug fix.
b/537635447
Testing details
Any backward incompatible change? If so, please explain.
No