test(negative_stat_cache): add integration tests for implicit directory negative stat cache - #4918
Open
alleaditya wants to merge 3 commits into
Open
Conversation
…ry negative stat cache
… buckets with implicit-dirs disabled
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces integration tests for negative stat cache behaviors (disabled, finite, and infinite) under various scenarios, including implicit directories, flat buckets with implicit directories disabled, and HNS folders. It also updates test_config.yaml to include test runs with the --implicit-dirs flag. The feedback recommends replacing assert.NoError with require.NoError before dereferencing returned pointers to avoid nil pointer dereference panics if a call fails. Additionally, it suggests refining the isImplicitDirsEnabled helper to correctly handle cases where --implicit-dirs=false is passed.
alleaditya
force-pushed
the
add_implicit_dir_cache_tests
branch
2 times, most recently
from
July 27, 2026 08:55
b8298ac to
654fe80
Compare
alleaditya
force-pushed
the
add_implicit_dir_cache_tests
branch
from
July 27, 2026 09:02
654fe80 to
b643cdc
Compare
alleaditya
marked this pull request as ready for review
July 27, 2026 12:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds comprehensive integration test coverage for implicit directory negative stat cache behavior across disabled, finite, and infinite negative stat cache TTL configurations in GCSFuse.
Key Updates:
tools/integration_tests/negative_stat_cachewith implicit directory negative stat cache tests.--implicit-dirs=falseto test negative file stat caching directly undertestDirPath.Link to the issue in case of a bug fix.
https://b.corp.google.com/issues/539425086
Testing details
go vet ./tools/integration_tests/negative_stat_cache/...andgofmt -s -w tools/integration_tests/negative_stat_cache/to ensure clean code formatting and linting.implicit_dirandnegative_stat_cacheintegration test packages against GCS bucketgs://gcsfuse-e2e-m2-worker1-1784797719:implicit_dirpackage: PASS (48/48 tests passed, 373.990s execution time)negative_stat_cachepackage: PASS (all tests passed across disabled, finite, and infinite cache configs, 355.666s execution time)Any backward incompatible change? If so, please explain.
N/A