test(read_cache): bifurcate read_cache local modification tests for rapid writes - #4982
test(read_cache): bifurcate read_cache local modification tests for rapid writes#4982vipnydav wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces several updates to the LRU cache implementation and integration tests. In lru.go, a size field is added to the entry struct to cache the entry size, preventing potential TOCTOU (Time-of-check to time-of-use) issues when entry sizes are updated dynamically. The invariant checks and cache operations are updated to use this cached size, and corresponding concurrency tests are added. Additionally, a missing file descriptor close is resolved in the integration test helpers, and integration tests are refactored to support rapid writes configurations for Pirlo buckets. As there are no review comments, I have no additional feedback to provide.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4982 +/- ##
==========================================
- Coverage 83.86% 83.85% -0.02%
==========================================
Files 173 173
Lines 21153 21160 +7
==========================================
+ Hits 17741 17744 +3
- Misses 2744 2747 +3
- Partials 668 669 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
7046338 to
8bfa21f
Compare
|
Hi @meet2mky, @raj-prince, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
a1200e1 to
5006443
Compare
|
Hi @meet2mky, @raj-prince, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
…modification_test.go
a51d2af to
ee1b435
Compare
Description
Fixes LRU entry size calculation to prevent underflow and bifurcates read_cache local modification tests to support separate test runners for base runs and rapid-writes enabled runs.
Testing details
Any backward incompatible change? If so, please explain.
No