Skip to content

test(implicit_dir): bifurcate implicit_dir tests for rapid writes flagsets - #4984

Open
vipnydav wants to merge 9 commits into
masterfrom
bifurcate-implicit-dir-rapid-writes
Open

test(implicit_dir): bifurcate implicit_dir tests for rapid writes flagsets#4984
vipnydav wants to merge 9 commits into
masterfrom
bifurcate-implicit-dir-rapid-writes

Conversation

@vipnydav

@vipnydav vipnydav commented Aug 3, 2026

Copy link
Copy Markdown
Member

Description

Bifurcates implicit_dir tests into TestImplicitDirBase and TestImplicitDirLocalFileRapidWritesEnabled while preserving both static and persistent mounting.

Testing details

  1. Unit tests - NA
  2. Integration tests - Done

Any backward incompatible change? If so, please explain.

No

@vipnydav
vipnydav requested a review from meet2mky as a code owner August 3, 2026 13:44
@vipnydav vipnydav added the execute-integration-tests Run only integration tests label Aug 3, 2026
@vipnydav
vipnydav requested a review from a team as a code owner August 3, 2026 13:44
@vipnydav
vipnydav requested a review from charith87 August 3, 2026 13:44
@vipnydav vipnydav added the execute-integration-tests Run only integration tests label Aug 3, 2026
@github-actions github-actions Bot added the remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR. label Aug 3, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the integration tests in the implicit_dir package to use the testify suite framework, converting standalone test functions into suite methods. It introduces implicitDirTestSuite and implicitDirLocalFileTest to support running tests with different mounting configurations (static and persistent) and under different bucket environments, specifically adding support for testing with rapid writes enabled or disabled on Pirlo buckets. Additionally, the test configuration YAML file is updated to specify the target test suites to run for various flag combinations, and the MountGcsfuseWithPersistentMountingWithConfigFile function is exported to be accessible from other packages. There are no review comments, so I have no feedback to provide.

@vipnydav vipnydav added the execute-integration-tests-on-zb To run E2E tests on zonal bucket. label Aug 3, 2026
@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (93ee10b) to head (9549292).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #4984       +/-   ##
==========================================
- Coverage   83.86%       0   -83.87%     
==========================================
  Files         173       0      -173     
  Lines       21153       0    -21153     
==========================================
- Hits        17741       0    -17741     
+ Misses       2744       0     -2744     
+ Partials      668       0      -668     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Hi @meet2mky, @charith87, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@vipnydav
vipnydav force-pushed the bifurcate-implicit-dir-rapid-writes branch from 91cb54b to ba20603 Compare August 5, 2026 08:07
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Hi @meet2mky, @charith87, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@vipnydav
vipnydav force-pushed the bifurcate-implicit-dir-rapid-writes branch from b1d19cf to 1385bbb Compare August 7, 2026 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

execute-integration-tests Run only integration tests execute-integration-tests-on-zb To run E2E tests on zonal bucket. remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant