test(implicit_dir): bifurcate implicit_dir tests for rapid writes flagsets - #4984
test(implicit_dir): bifurcate implicit_dir tests for rapid writes flagsets#4984vipnydav wants to merge 9 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the integration tests in the implicit_dir package to use the testify suite framework, converting standalone test functions into suite methods. It introduces implicitDirTestSuite and implicitDirLocalFileTest to support running tests with different mounting configurations (static and persistent) and under different bucket environments, specifically adding support for testing with rapid writes enabled or disabled on Pirlo buckets. Additionally, the test configuration YAML file is updated to specify the target test suites to run for various flag combinations, and the MountGcsfuseWithPersistentMountingWithConfigFile function is exported to be accessible from other packages. There are no review comments, so I have no feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4984 +/- ##
==========================================
- Coverage 83.86% 0 -83.87%
==========================================
Files 173 0 -173
Lines 21153 0 -21153
==========================================
- Hits 17741 0 -17741
+ Misses 2744 0 -2744
+ Partials 668 0 -668
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Hi @meet2mky, @charith87, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
91cb54b to
ba20603
Compare
|
Hi @meet2mky, @charith87, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
…n test_config.yaml
b1d19cf to
1385bbb
Compare
Description
Bifurcates implicit_dir tests into TestImplicitDirBase and TestImplicitDirLocalFileRapidWritesEnabled while preserving both static and persistent mounting.
Testing details
Any backward incompatible change? If so, please explain.
No