Skip to content

test(readonly_creds): bifurcate readonly_creds tests for rapid writes flagsets - #4985

Open
vipnydav wants to merge 3 commits into
masterfrom
bifurcate-readonly-creds-rapid-writes
Open

test(readonly_creds): bifurcate readonly_creds tests for rapid writes flagsets#4985
vipnydav wants to merge 3 commits into
masterfrom
bifurcate-readonly-creds-rapid-writes

Conversation

@vipnydav

@vipnydav vipnydav commented Aug 3, 2026

Copy link
Copy Markdown
Member

Description

Bifurcates readonly_creds tests into TestReadOnlyCredsBase and TestReadOnlyCredsRapidWritesEnabled and adds RunSuiteForDifferentAuthMethods helper to support multi-auth execution.

Testing details

  1. Unit tests - NA
  2. Integration tests - Done

Any backward incompatible change? If so, please explain.

No

@vipnydav
vipnydav requested a review from meet2mky as a code owner August 3, 2026 13:45
@vipnydav vipnydav added the execute-integration-tests Run only integration tests label Aug 3, 2026
@vipnydav
vipnydav requested a review from a team as a code owner August 3, 2026 13:45
@github-actions github-actions Bot added the remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR. label Aug 3, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the integration tests for readonly_creds to support testing with rapid writes enabled, specifically targeting Pirlo buckets. It introduces configuration changes to run separate test suites for rapid writes and refactors the test runner to execute tests across different authentication methods. The feedback suggests addressing potential nil pointer dereferences in failure_during_file_sync_test.go by asserting that files are opened successfully. Additionally, it is recommended to refactor both the flag-set execution and the authentication method runner in creds.go to use t.Run subtests, which will isolate test failures and prevent abrupt process termination.

Comment thread tools/integration_tests/util/creds_tests/creds.go
@vipnydav vipnydav added the execute-integration-tests-on-zb To run E2E tests on zonal bucket. label Aug 3, 2026
@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (93ee10b) to head (a115f09).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #4985       +/-   ##
==========================================
- Coverage   83.86%       0   -83.87%     
==========================================
  Files         173       0      -173     
  Lines       21153       0    -21153     
==========================================
- Hits        17741       0    -17741     
+ Misses       2744       0     -2744     
+ Partials      668       0      -668     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vipnydav
vipnydav force-pushed the bifurcate-readonly-creds-rapid-writes branch from f7b44bc to b7ae615 Compare August 3, 2026 17:38
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Hi @meet2mky, @vadlakondaswetha, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@vipnydav
vipnydav force-pushed the bifurcate-readonly-creds-rapid-writes branch from 76b384d to 9b704d3 Compare August 5, 2026 08:07
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Hi @meet2mky, @vadlakondaswetha, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@vipnydav
vipnydav force-pushed the bifurcate-readonly-creds-rapid-writes branch from 669ee6d to fbe124d Compare August 7, 2026 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

execute-integration-tests Run only integration tests execute-integration-tests-on-zb To run E2E tests on zonal bucket. remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant