test(readonly_creds): bifurcate readonly_creds tests for rapid writes flagsets - #4985
test(readonly_creds): bifurcate readonly_creds tests for rapid writes flagsets#4985vipnydav wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the integration tests for readonly_creds to support testing with rapid writes enabled, specifically targeting Pirlo buckets. It introduces configuration changes to run separate test suites for rapid writes and refactors the test runner to execute tests across different authentication methods. The feedback suggests addressing potential nil pointer dereferences in failure_during_file_sync_test.go by asserting that files are opened successfully. Additionally, it is recommended to refactor both the flag-set execution and the authentication method runner in creds.go to use t.Run subtests, which will isolate test failures and prevent abrupt process termination.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4985 +/- ##
==========================================
- Coverage 83.86% 0 -83.87%
==========================================
Files 173 0 -173
Lines 21153 0 -21153
==========================================
- Hits 17741 0 -17741
+ Misses 2744 0 -2744
+ Partials 668 0 -668
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
f7b44bc to
b7ae615
Compare
|
Hi @meet2mky, @vadlakondaswetha, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
76b384d to
9b704d3
Compare
|
Hi @meet2mky, @vadlakondaswetha, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
669ee6d to
fbe124d
Compare
Description
Bifurcates readonly_creds tests into TestReadOnlyCredsBase and TestReadOnlyCredsRapidWritesEnabled and adds RunSuiteForDifferentAuthMethods helper to support multi-auth execution.
Testing details
Any backward incompatible change? If so, please explain.
No