fix(storage): do not enforce DirectPath for Rapid buckets - #4987
Open
alleaditya wants to merge 2 commits into
Open
fix(storage): do not enforce DirectPath for Rapid buckets#4987alleaditya wants to merge 2 commits into
alleaditya wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates createGRPCClientHandle to skip DirectPath enforcement and verification for rapid buckets, while also correcting the casing of the isBucketRapid parameter. Additionally, unit tests are added to verify this behavior. The feedback suggests using require.NoError and require.NotNil in the new tests to fail immediately and simplify the client cleanup logic.
alleaditya
force-pushed
the
plan_suggestion_541764145
branch
2 times, most recently
from
August 4, 2026 08:00
dedd676 to
0eebca1
Compare
alleaditya
marked this pull request as ready for review
August 4, 2026 08:44
Collaborator
|
How do you enforce the direct path for rapid when customer sets Line 693 in a3cca53 @vadlakondaswetha This is not going to be handled correctly if this is not enforced. We have to fix the fallback here. |
meet2mky
reviewed
Aug 4, 2026
alleaditya
force-pushed
the
plan_suggestion_541764145
branch
from
August 4, 2026 17:15
0eebca1 to
31784ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In GCSFuse,
createGRPCClientHandleininternal/storage/storage_handle.gopreviously attachedexperimental.WithDirectConnectivityEnforced()unconditionally for all gRPC clients.For Rapid buckets, DirectPath is not supported/enforced. Forcing DirectPath headers causes GCS servers to reject non-DirectPath requests once DirectPath enforcement is active.
This change:
experimental.WithDirectConnectivityEnforced()whenisBucketRapidistrue.verifyDirectPathConnectivity) for Rapid buckets to avoid unnecessary dummy Stat API call retries, latency, and warning logs.internal/storage/storage_handle_test.go.Link to the issue in case of a bug fix.
Fixes b/541764145
Testing details
scratch/verify_grpc_headers.shconfirming header and DirectPath handling for Rapid vs Non-Rapid buckets.TestCreateGRPCClientHandle_RapidBucketandTestCreateGRPCClientHandle_NonRapidBucketin./internal/storage. Tests pass cleanly (0.00s execution for Rapid bucket).go test -v ./internal/storage).Any backward incompatible change? If so, please explain.
No