fix: Creating non dp grpc client when dp check fails - #4989
fix: Creating non dp grpc client when dp check fails#4989vadlakondaswetha wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the gRPC client creation and DirectPath verification logic, replacing the rapid bucket check with an explicit DirectPath enforcement flag and introducing a unified client creation helper. It also adds comprehensive unit tests to validate the fallback behavior under different strategies. The feedback suggests removing the explicit client close call during verification failure, as the garbage collector handles resource cleanup.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4989 +/- ##
==========================================
+ Coverage 83.85% 83.97% +0.11%
==========================================
Files 173 173
Lines 21171 21204 +33
==========================================
+ Hits 17752 17805 +53
+ Misses 2750 2734 -16
+ Partials 669 665 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Hi @abhishek10004, @meet2mky, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
2 similar comments
|
Hi @abhishek10004, @meet2mky, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
|
Hi @abhishek10004, @meet2mky, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
For rapid, if direct path doesnt work and server rejects the non dp calls as part of dp verification check, then we are ignoring the error and continuing with the mount. The problem with this approach is that since we are passing withDPEnforced header for every call, any call made to GCS after mount will also be rejected by the server.
To avoid this, we should create a new gRPC client which doesnt pass the header if dp check fails.
Note: Today server rejecting non dp calls is behind whitelisting and not fully rolled out.
Description
Link to the issue in case of a bug fix.
Testing details
Any backward incompatible change? If so, please explain.