Skip to content

chore(vertexai): Remove unused code safety-settings#5647

Open
amcolin wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
amcolin:remove-vertexai-safety-settings
Open

chore(vertexai): Remove unused code safety-settings#5647
amcolin wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
amcolin:remove-vertexai-safety-settings

Conversation

@amcolin

@amcolin amcolin commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes Internal b/534897157

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Jul 14, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the entire safety-settings sample module under vertexai, including its Go module configuration, implementation, and associated tests. As there are no review comments, I have no feedback to provide.

@amcolin
amcolin force-pushed the remove-vertexai-safety-settings branch from e26d1b2 to 7cc50d1 Compare July 15, 2026 16:55

@Kef131 Kef131 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@amcolin
amcolin marked this pull request as ready for review July 15, 2026 18:12
@amcolin
amcolin requested review from a team as code owners July 15, 2026 18:12

@angelcaamal angelcaamal left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are no references to these samples, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants