Skip to content

colab: add workbench_runtime support to google_colab_notebook_execution - #18561

Open
slevenick wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
slevenick:mm-b-543479217
Open

colab: add workbench_runtime support to google_colab_notebook_execution#18561
slevenick wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
slevenick:mm-b-543479217

Conversation

@slevenick

Copy link
Copy Markdown
Contributor

Add support for workbench_runtime and nested vm_image (project, name, family) fields in google_colab_notebook_execution.

Fixes b/543479217

colab: added `workbench_runtime` and `workbench_runtime.vm_image` fields to `google_colab_notebook_execution` resource

@modular-magician

modular-magician commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a8c0fd4:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 3 files changed, 208 insertions(+), 4 deletions(-)
google-beta provider View Diff 4 files changed, 215 insertions(+), 4 deletions(-)
terraform-google-conversion View Diff 4 files changed, 260 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_notebook_execution (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_notebook_execution" "primary" {
  workbench_runtime {
    vm_image {
      name = # value needed
    }
  }
}

Test report

Analytics

Total Tests Passed Skipped Affected
22 21 0 1
Affected Service Packages
  • colab

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccColabNotebookExecution_colabNotebookExecutionFullExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccColabNotebookExecution_colabNotebookExecutionFullExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@slevenick VCR tests complete for a8c0fd4!

@modular-magician

modular-magician commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 04e906a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 165 insertions(+), 6 deletions(-)
google-beta provider View Diff 4 files changed, 174 insertions(+), 8 deletions(-)
terraform-google-conversion View Diff 5 files changed, 264 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_notebook_execution (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_notebook_execution" "primary" {
  workbench_runtime {
    vm_image {
      name = # value needed
    }
  }
}

Test report

Analytics

Total Tests Passed Skipped Affected
22 21 0 1
Affected Service Packages
  • colab

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccColabNotebookExecution_colabNotebookExecutionFullExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccColabNotebookExecution_colabNotebookExecutionFullExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@slevenick VCR tests complete for 04e906a!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants