cloudbuild: Add list resources for Trigger and BitbucketServerConfig - #18562
cloudbuild: Add list resources for Trigger and BitbucketServerConfig#18562BBBmau wants to merge 2 commits into
Conversation
… collection_url_key - Mark location parameter as required (remove default_value: 'global') so the generated list resource requires location as a filter field - Add collection_url_key: 'triggers' to match the actual API response key (api_resource_type_kind: BuildTrigger was generating 'buildTriggers', but the Cloud Build API returns the list under the 'triggers' key) Both TestAccCloudBuildTriggerListQuery_generated and TestAccCloudBuildBitbucketServerConfigListQuery_generated now pass.
|
@modular-magician reassign-reviewer |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit dba48d3: Diff reportYour PR generated the following diffs in downstream repositories:
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 16 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @BBBmau, @rileykarson VCR tests complete for dba48d3! |
Add list resource support for CloudBuild Trigger and BitbucketServerConfig resources.
This enables users to query and list existing CloudBuild Triggers and BitbucketServerConfig resources using Terraform data sources.
Testing:
TestAccCloudBuildBitbucketServerConfigListQuery_generated— PASSTestAccCloudBuildTriggerListQuery_generated— PASSFixes included:
required: truefor Trigger resourcecollection_url_key: 'triggers'for Trigger resource to match API response schema