container: add node_pool_upgrade_concurrency_config to google_container_cluster - #18571
Open
KyriosGN0 wants to merge 1 commit into
Open
Conversation
…er_cluster Beta-only cluster field capping how many node pools GKE auto-upgrades concurrently. Clearing follows the workload_identity_config pattern: an explicit zero max_count with ForceSendFields, since GKE's update is not RESTful and omitting the field is a no-op. Signed-off-by: AvivGuiser <avivguiser@gmail.com>
modular-magician
added
the
awaiting-approval
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
node_pool_upgrade_concurrency_configblock with amax_countfield togoogle_container_cluster, mapping toCluster.nodePoolUpgradeConcurrencyConfigandClusterUpdate.desiredNodePoolUpgradeConcurrencyConfig.max_countwithForceSendFields, matching howworkload_identity_configalready handles GKE's non-RESTful update.Why
gcloud beta container clusters update --node-pool-upgrade-concurrency-config, but had no Terraform equivalent.container/v1— so schema, expand, flatten, create, read and update are all behind version guards, and the field is excluded from the GA meta.yaml.Optionaland notComputed: GKE returns no value for it on a cluster that never set it, so marking it Computed would only make the block impossible to clear.