sql: add replication_lag_max_seconds to google_sql_database_instance - #18572
Open
KyriosGN0 wants to merge 1 commit into
Open
sql: add replication_lag_max_seconds to google_sql_database_instance#18572KyriosGN0 wants to merge 1 commit into
KyriosGN0 wants to merge 1 commit into
Conversation
modular-magician
added
the
awaiting-approval
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
KyriosGN0
force-pushed
the
sql-replication-lag-max-seconds
branch
from
August 8, 2026 06:56
44ce94c to
966c5d4
Compare
Exposes settings.replicationLagMaxSeconds (GA in the Cloud SQL Admin API) on google_sql_database_instance. Controls read-replica recreation after sustained replication lag; 0 disables the check. Signed-off-by: AvivGuiser <avivguiser@gmail.com>
KyriosGN0
force-pushed
the
sql-replication-lag-max-seconds
branch
from
August 8, 2026 09:00
966c5d4 to
4929f32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
replication_lag_max_secondsto thesettingsblock ofgoogle_sql_database_instance, wiring the existing Cloud SQL Admin API fieldSettings.replicationLagMaxSeconds.TypeInt, optional/computed,validation.IntAtLeast(0).expandSqlDatabaseInstanceSettings/flattenSettings.TestAccSqlDatabaseInstance_replicationLagMaxSeconds.Why
The field is GA in the Cloud SQL Admin API (present in both
v1andv1beta4) but was not exposed by the provider. It controls automatic read-replica recreation once replication lag exceeds the threshold (0disables the check), so users relying on replica-freshness could not manage it declaratively.No dependency bump:
google.golang.org/apialready vendorsSettings.ReplicationLagMaxSeconds.