notebooks: remove deprecated google_notebooks_* resources (8.0.0)

[bcreddy-gcp]

Summary

Removes the deprecated google_notebooks_* resources for the 8.0.0 major release. The underlying Vertex AI Workbench User-Managed and Google-Managed Notebooks products have reached End of Life; users should migrate to google_workbench_instance.

Resources removed:

• google_notebooks_instance (+ _iam_policy / _iam_binding / _iam_member)
• google_notebooks_runtime (+ _iam_policy / _iam_binding / _iam_member)
• google_notebooks_environment

Deprecation notices for these resources are already present on main. This PR also adds version_8_upgrade.html.markdown entries and removes the notebooks IAM converter registrations (and unused import) from the TGC resource_converters.go.tmpl.

google_notebooks_location was already removed in 7.0.0, so it is not included here.

Fixes hashicorp/terraform-provider-google#23249

Note

Draft: opened to run downstream generation/build/tests via CI. Not yet locally generated/built.

Release Note

notebooks: removed the deprecated `google_notebooks_instance`, `google_notebooks_runtime`, and `google_notebooks_environment` resources, along with the `google_notebooks_instance_iam_*` and `google_notebooks_runtime_iam_*` resources. Migrate to `google_workbench_instance`.

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8396965:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	35 files changed, 12 insertions(+), 11261 deletions(-)
google-beta provider	View Diff	35 files changed, 12 insertions(+), 11466 deletions(-)
terraform-google-conversion	View Diff	10 files changed, 2729 deletions(-)

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Resource google_notebooks_environment was either removed or renamed - reference
• Resource google_notebooks_instance_iam_binding was either removed or renamed - reference
• Resource google_notebooks_instance_iam_member was either removed or renamed - reference
• Resource google_notebooks_instance_iam_policy was either removed or renamed - reference
• Resource google_notebooks_instance was either removed or renamed - reference
• Resource google_notebooks_runtime_iam_binding was either removed or renamed - reference
• Resource google_notebooks_runtime_iam_member was either removed or renamed - reference
• Resource google_notebooks_runtime_iam_policy was either removed or renamed - reference
• Resource google_notebooks_runtime was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Errors

google-beta provider:

• Error reading file website/docs/d/notebooks_instance_iam_policy.html.markdown
• Error reading file website/docs/d/notebooks_runtime_iam_policy.html.markdown
• Error reading file website/docs/r/notebooks_environment.html.markdown
• Error reading file website/docs/r/notebooks_instance.html.markdown
• Error reading file website/docs/r/notebooks_instance_iam.html.markdown
• Error reading file website/docs/r/notebooks_runtime.html.markdown
• Error reading file website/docs/r/notebooks_runtime_iam.html.markdown

Test report

Analytics

Total Tests	Passed	Skipped	Affected
6859	6108	704	47

Affected Service Packages

• All service packages are affected

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 47 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccBigqueryReservationReservationAssignment_bareNameWithoutLocation
• TestAccBigqueryReservationReservationAssignment_bigqueryReservationAssignmentBasicExample
• TestAccBigqueryReservationReservationAssignment_bigqueryReservationAssignmentFullExample
• TestAccBigqueryReservationReservationAssignment_bigqueryReservationAssignmentFullWithPrincipalExample
• TestAccBigqueryReservationReservation_bigqueryReservationBasicExample
• TestAccBigqueryReservationReservation_bigqueryReservationWithDisasterRecoveryExample
• TestAccBigqueryReservation_reservationGroup_update
• TestAccBigqueryReservation_withDisasterRecovery_update
• TestAccBigqueryReservation_withScalingMode_update
• TestAccCESDeployment_cesDeploymentBasicExample
• TestAccCESDeployment_cesDeploymentFullExample
• TestAccCESDeployment_update
• TestAccChronicleRuleDeployment_chronicleRuledeploymentBasicExample
• TestAccChronicleRuleDeployment_chronicleRuledeploymentBasicExample_update
• TestAccComputeInstanceFromMachineImage_diffProject
• TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample
• TestAccComputeRegionTargetTcpProxy_regionTargetTcpProxyBasicExample
• TestAccComputeRouterPeer_AddMd5AuthenticationKey
• TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
• TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
• TestAccComputeServiceAttachment_connectionLimitUpdate
• TestAccComputeServiceAttachment_consumerAcceptListsPermadiff
• TestAccComputeServiceAttachment_serviceAttachmentBasicExampleGateway
• TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate
• TestAccComputeServiceAttachment_serviceAttachmentCrossRegionIlbExample
• TestAccComputeServiceAttachment_serviceAttachmentEndpointUrl
• TestAccComputeServiceAttachment_serviceAttachmentExplicitNetworksExample
• TestAccComputeServiceAttachment_serviceAttachmentTunnelingConfigExample
• TestAccComputeServiceAttachment_targetServiceInPlaceUpdate
• TestAccComputeServiceAttachment_tunnelingConfigUpdate
• TestAccDataSourceGoogleComputeServiceAttachment_basic
• TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
• TestAccDeveloperConnectAccountConnector_GlePrivAccountConnector
• TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
• TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
• TestAccPubsubSubscription_pubsubSubscriptionTagsExample
• TestAccSqlDatabaseInstance_withPSCEnabled_thenAddAllowedConsumerProjects_thenRemoveAllowedConsumerProject
• TestAccSqlDatabaseInstance_withPSCEnabled_thenAddPscAutoConnections_thenRemovePscAutoConnections
• TestAccSqlDatabaseInstance_withPSCEnabled_withEmptyAllowedConsumerProjects
• TestAccSqlDatabaseInstance_withPSCEnabled_withIpV4Enabled
• TestAccSqlDatabaseInstance_withPSCEnabled_withPscAutoConnections
• TestAccSqlDatabaseInstance_withPSCEnabled_withoutAllowedConsumerProjects
• TestAccSqlDatabaseInstance_withPSCEnabled_withoutPscAutoConnections
• TestAccSqlDatabaseInstance_withPscEnabled_withNetworkAttachmentUriOnCreate
• TestAccSqlDatabaseInstance_withPscEnabled_withNetworkAttachmentUri_thenRemoveNetworkAttachment
• TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated
• TestAccVertexAIReasoningEngine_vertexAiReasoningEngineContextSpecExample

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccBigqueryReservationReservationAssignment_bareNameWithoutLocation
✅ Log	✅	TestAccBigqueryReservationReservationAssignment_bigqueryReservationAssignmentBasicExample
✅ Log	✅	TestAccBigqueryReservationReservationAssignment_bigqueryReservationAssignmentFullExample
✅ Log	✅	TestAccBigqueryReservationReservationAssignment_bigqueryReservationAssignmentFullWithPrincipalExample
✅ Log	✅	TestAccBigqueryReservationReservation_bigqueryReservationBasicExample
✅ Log	✅	TestAccBigqueryReservationReservation_bigqueryReservationWithDisasterRecoveryExample
✅ Log	✅	TestAccBigqueryReservation_reservationGroup_update
✅ Log	✅	TestAccBigqueryReservation_withDisasterRecovery_update
✅ Log	✅	TestAccBigqueryReservation_withScalingMode_update
✅ Log	✅	TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample
✅ Log	✅	TestAccComputeRegionTargetTcpProxy_regionTargetTcpProxyBasicExample
✅ Log	✅	TestAccComputeRouterPeer_AddMd5AuthenticationKey
✅ Log	✅	TestAccComputeServiceAttachment_connectionLimitUpdate
✅ Log	✅	TestAccComputeServiceAttachment_consumerAcceptListsPermadiff
✅ Log	✅	TestAccComputeServiceAttachment_serviceAttachmentBasicExampleGateway
✅ Log	✅	TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate
✅ Log	✅	TestAccComputeServiceAttachment_serviceAttachmentCrossRegionIlbExample
✅ Log	✅	TestAccComputeServiceAttachment_serviceAttachmentEndpointUrl
✅ Log	✅	TestAccComputeServiceAttachment_serviceAttachmentExplicitNetworksExample
✅ Log	✅	TestAccComputeServiceAttachment_serviceAttachmentTunnelingConfigExample
✅ Log	✅	TestAccComputeServiceAttachment_targetServiceInPlaceUpdate
✅ Log	✅	TestAccComputeServiceAttachment_tunnelingConfigUpdate
✅ Log	✅	TestAccDataSourceGoogleComputeServiceAttachment_basic
✅ Log	✅	TestAccSqlDatabaseInstance_withPSCEnabled_thenAddAllowedConsumerProjects_thenRemoveAllowedConsumerProject
✅ Log	✅	TestAccSqlDatabaseInstance_withPSCEnabled_thenAddPscAutoConnections_thenRemovePscAutoConnections
✅ Log	✅	TestAccSqlDatabaseInstance_withPSCEnabled_withEmptyAllowedConsumerProjects
✅ Log	✅	TestAccSqlDatabaseInstance_withPSCEnabled_withIpV4Enabled
✅ Log	✅	TestAccSqlDatabaseInstance_withPSCEnabled_withPscAutoConnections
✅ Log	✅	TestAccSqlDatabaseInstance_withPSCEnabled_withoutAllowedConsumerProjects
✅ Log	✅	TestAccSqlDatabaseInstance_withPSCEnabled_withoutPscAutoConnections
✅ Log	✅	TestAccSqlDatabaseInstance_withPscEnabled_withNetworkAttachmentUriOnCreate
✅ Log	✅	TestAccSqlDatabaseInstance_withPscEnabled_withNetworkAttachmentUri_thenRemoveNetworkAttachment
✅ Log	✅	TestAccVertexAIReasoningEngine_vertexAiReasoningEngineContextSpecExample
✅ Log	❌ Error · Log	TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
❌ Error · Log	-	TestAccCESDeployment_cesDeploymentBasicExample
❌ Error · Log	-	TestAccCESDeployment_cesDeploymentFullExample
❌ Error · Log	-	TestAccCESDeployment_update
❌ Error · Log	-	TestAccChronicleRuleDeployment_chronicleRuledeploymentBasicExample
❌ Error · Log	-	TestAccChronicleRuleDeployment_chronicleRuledeploymentBasicExample_update
❌ Error · Log	-	TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log	-	TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
❌ Error · Log	-	TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log	-	TestAccDeveloperConnectAccountConnector_GlePrivAccountConnector
❌ Error · Log	-	TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log	-	TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log	-	TestAccPubsubSubscription_pubsubSubscriptionTagsExample
❌ Error · Log	-	TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@bcreddy-gcp, @c2thorn VCR tests complete for 8396965!