Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 2.12.1 tests to the dashboard #940

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

chandrasekhard2
Copy link
Collaborator

Description

Adding 2.12.1 tests to the dashboard

Tests

N/A

Instruction and/or command lines to reproduce your tests: ...

N/A

List links for your tests (use go/shortn-gen for any internal link): ...

N/A

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run one-shot tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@RissyRan
Copy link
Collaborator

RissyRan commented Jul 6, 2023

Thanks for adding tf. to tf.nightly-se

@RissyRan RissyRan self-requested a review July 6, 2023 22:50
Copy link
Collaborator

@RissyRan RissyRan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chandrasekhard2
Copy link
Collaborator Author

I think you will need to add tf. to all SE tests? i.e. https://github.com/GoogleCloudPlatform/ml-testing-accelerators/blob/master/tests/tensorflow/nightly-se/common.libsonnet#L26

Its already tf. . Where exactly do we need to add that?

@chandrasekhard2
Copy link
Collaborator Author

I think you will need to add tf. to all SE tests? i.e. https://github.com/GoogleCloudPlatform/ml-testing-accelerators/blob/master/tests/tensorflow/nightly-se/common.libsonnet#L26

This is only for 2.12.1. Can you request Hyesoo to change it?

@chandrasekhard2 chandrasekhard2 requested a review from RissyRan July 6, 2023 23:06
@RissyRan
Copy link
Collaborator

RissyRan commented Jul 6, 2023

Hi @hyeygit, Chandra is updating nightly-se to tf.nightly-se for consistence. Could you send a separate a PR to address that in your tests? Otherwise, SE tests won't be shown on the dashboard.

https://github.com/GoogleCloudPlatform/ml-testing-accelerators/blob/master/tests/tensorflow/nightly-se/common.libsonnet#L26

https://github.com/GoogleCloudPlatform/ml-testing-accelerators/blob/master/tests/tensorflow/nightly-se/common.libsonnet#L45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants