-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Update Gemma on Dataflow example to pass max_length as arg #11897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Got a clean run using this version of the code on a different GCP project since the test runs here have been hitting compute quotas |
We got this warning, although not the source of the errors:
|
Looks like tests failed due to timeout. |
This might require updating to the latest branch, secrets have changed and it might be using an older image version. |
@jrmccluskey per the earlier comment, this PR will need rebasing before test can run |
Description
Passes the max_length parameter to Gemma's
generate()
call through inference_args rather than having a hard-coded option.Checklist
nox -s py-3.9
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)