Skip to content

chore(deps): bump deps for generative_ai/embeddings #13239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Conversation

glasnt
Copy link
Contributor

@glasnt glasnt commented Mar 18, 2025

Description

Resolves CI issues with #12851, #12861, #12865, #12947, #12952, #12959, #12975, #13152

Fixes #12995

Based on local testing, updating the pandas (#13152) and google-cloud-aiplatform (#12865) version to latest resolves the NoneType issue.

  • Please merge this PR for me once it is approved
  • Please rebase linked PRs after merging

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Mar 18, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @glasnt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request updates the dependencies for the generative_ai/embeddings module. Specifically, it bumps the versions of pandas and google-cloud-aiplatform. The stated intent is to resolve CI issues and a NoneType issue, as well as address several other issues mentioned in the description. The PR description indicates that local testing suggests these updates resolve the NoneType issue.

Highlights

  • Dependency Update: Updates the pandas dependency from 2.1.4 to 2.2.3 for Python versions greater than 3.8.
  • Dependency Update: Updates the google-cloud-aiplatform[all] dependency from 1.69.0 to 1.84.0.
  • Dependency Removal: Removes the langchain-core and langchain-google-vertexai dependencies.

Changelog

  • generative_ai/embeddings/requirements.txt
    • Updated pandas version from 2.1.4 to 2.2.3 for Python versions > 3.8 (line 3).
    • Updated google-cloud-aiplatform[all] version from 1.69.0 to 1.84.0 (line 6).
    • Removed langchain-core==0.2.33 (line 10).
    • Removed langchain-google-vertexai==1.0.10 (line 11).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


In realms of code, where versions sway,
A dependency's call can light the way.
Pandas ascend, AI's cloud takes flight,
To banish bugs and set things right.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the dependencies for the generative_ai/embeddings project. The updates include pandas and google-cloud-aiplatform. The PR description indicates that these updates resolve CI issues and a NoneType issue. The changes seem straightforward and necessary for maintaining the project's stability and compatibility.

Merge Readiness

The pull request updates dependencies to resolve CI issues and a NoneType issue. Given the description and the nature of the changes, it seems like a necessary update. I am unable to directly approve the pull request, and users should have others review and approve this code before merging. Since the PR description indicates that these updates resolve critical issues, I would recommend merging this PR once it passes CI.

@glasnt glasnt marked this pull request as ready for review March 18, 2025 01:00
@glasnt glasnt requested review from a team as code owners March 18, 2025 01:00
@holtskinner holtskinner merged commit f13214d into main Mar 18, 2025
14 checks passed
@holtskinner holtskinner deleted the nonetype branch March 18, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[generative_ai] Test for embeddings fails on CI
3 participants