-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Add sample code for model_selection_config #13325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sample code for model_selection_config #13325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @yan283, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request adds sample code for model_selection_config
to the text_generation
example. It updates the google-genai
dependency to version 1.11.0 and modifies the code to include ModelSelectionConfig
in the GenerateContentConfig
when calling the generate_content
method. The API version is also updated to v1beta1
.
Highlights
- Model Selection Configuration: The pull request introduces the use of
ModelSelectionConfig
to specify feature selection preferences when generating content. - API Version Update: The API version is updated from
v1
tov1beta1
to support the newModelSelectionConfig
feature. - Dependency Update: The
google-genai
dependency is updated from version 1.7.0 to 1.11.0.
Changelog
- genai/text_generation/model_optimizer_textgen_with_txt.py
- Imports
FeatureSelectionPreference
,GenerateContentConfig
, andModelSelectionConfig
fromgoogle.genai.types
. - Updates the
Client
initialization to useapi_version="v1beta1"
. - Adds a
config
parameter to thegenerate_content
call, including amodel_selection_config
with afeature_selection_preference
set toFeatureSelectionPreference.BALANCED
.
- Imports
- genai/text_generation/requirements.txt
- Updates the
google-genai
dependency from version 1.7.0 to 1.11.0.
- Updates the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A model's selection,
Configs shape its perfection,
AI's guiding hand.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces the model_selection_config
to the text generation example, allowing users to specify a preference for model selection (quality vs. cost). The code changes look good overall, but there are a few minor suggestions for improvement.
Merge Readiness
The code changes are well-structured and introduce a useful feature. I recommend addressing the comments before merging. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging.
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)