Skip to content

Conversation

dkurzaj
Copy link

@dkurzaj dkurzaj commented Oct 3, 2025

Description

Fixes #10805

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@dkurzaj dkurzaj requested review from a team as code owners October 3, 2025 12:51
Copy link

google-cla bot commented Oct 3, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added api: composer Issues related to the Cloud Composer API. samples Issues that are directly related to samples. labels Oct 3, 2025
Copy link
Contributor

Summary of Changes

Hello @dkurzaj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Cloud Composer DAG management script by enabling the pausing or unpausing of all DAGs in an environment with a single command. The change intelligently detects the Airflow version to apply the most efficient method: new bulk operations for modern Airflow versions (2.9.0+) and the existing iterative approach for older versions. This improvement streamlines DAG management and ensures compatibility across different Composer environments.

Highlights

  • Bulk DAG Operations: Introduced new static methods pause_all_dags and unpause_all_dags in composer_dags.py to allow pausing or unpausing all DAGs within a Google Cloud Composer environment in a single operation, leveraging gcloud commands with regex.
  • Airflow Version Compatibility: Implemented logic to differentiate between Airflow versions. For Airflow versions 2.9.0 and above, the new bulk operations are used. For older versions, the existing per-DAG iteration logic is maintained to ensure backward compatibility.
  • Code Refactoring: The main function in composer_dags.py was refactored to separate the version-specific logic into legacy_operations and modern_operations functions, improving code organization and readability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an excellent optimization for pausing and unpausing DAGs by leveraging native gcloud features for newer Airflow versions, which avoids iterating through each DAG individually. My review focuses on improving the robustness and correctness of the new functions. I've identified a critical issue with the copied retry logic which is currently non-functional, and I've provided suggestions to correct this. Additionally, I've included feedback on improving type hints and code style for better maintainability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: composer Issues related to the Cloud Composer API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Composer_dags.py script (pause & unpause dags) is taking hours to finish
2 participants