Animations: hardening to prevent animations on first page#14404
Merged
swissspidy merged 4 commits intomainfrom Nov 24, 2025
Merged
Animations: hardening to prevent animations on first page#14404swissspidy merged 4 commits intomainfrom
swissspidy merged 4 commits intomainfrom
Conversation
swissspidy
added
Type: Bug
Summary of ChangesHello @swissspidy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces robust measures to ensure that animations are correctly suppressed on the first page of a story. The primary goal is to prevent a scenario where elements on the initial page might be inadvertently hidden due to animation states, thereby improving content visibility and user experience. The solution tackles both the generation of animation data during story creation and provides a runtime CSS fallback for existing stories. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request hardens the system against animations on the first page by preventing animation markup generation and adding a CSS fallback. The changes are logical and well-implemented. I have one suggestion to improve the efficiency of how the CSS fallback is added by reusing an existing <style> tag, which will help keep the DOM cleaner.
Contributor
|
Size Change: +14 B (0%) Total Size: 2.99 MB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses report at https://wordpress.org/support/topic/older-stories-have-blank-pages-elements-that-wont-load/
1st page animations are usually prevent in the editor, but one could still move a page with animations to the front. But then they would be prevented by the format itself. However, that doesn't seem to be the case (anymore?). This caused elements to be hidden in their pre-animation state.
This PR fixes this in two ways:
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #