Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Add attendance check-in/out validation to completeShift
Summary
Adds guard attendance validation to the
completeShiftroute, preventing a shift from being marked complete unless the assigned guard has both checked in and checked out.Changes
Shift Model (
Shift.js)attendancevirtual populate referencingShiftAttendanceviashiftIdhasCheckedInvirtual — returnstrueifattendance.checkInTimeis not nullhasCheckedOutvirtual — returnstrueifattendance.checkOutTimeis not nullcompleteShiftRoute400with'Guard has not checked in'ifhasCheckedInis false400with'Guard has not checked out'ifhasCheckedOutis falseWhy
Previously, a shift could be completed without any attendance record, which could lead to inaccurate shift data. This validation ensures attendance is properly recorded before a shift is closed out.
Test Cases:

Unable to mark complete without guard checkin
Unable to mark complete without guard checkout

Shift completed after complete checkin/checkout from guard
