Skip to content

Refactor inline styles in TimeSheetsScreen#255

Open
chaitanyakotagiri27 wants to merge 1 commit intomainfrom
refactor/timesheet-inline-style
Open

Refactor inline styles in TimeSheetsScreen#255
chaitanyakotagiri27 wants to merge 1 commit intomainfrom
refactor/timesheet-inline-style

Conversation

@chaitanyakotagiri27
Copy link
Copy Markdown
Collaborator

Moved the inline padding style from FlatList into the StyleSheet by creating a listContainer style.

Applied the new style using contentContainerStyle to replace the inline style.Style

image image

@Krisha190235
Copy link
Copy Markdown
Collaborator

Please only include changes related to refactoring inline styles in TimeSheetsScreen; other functional/UI changes should be removed or moved to a separate PR before merging PR into main.

@chaitanyakotagiri27
Copy link
Copy Markdown
Collaborator Author

Please only include changes related to refactoring inline styles in TimeSheetsScreen; other functional/UI changes should be removed or moved to a separate PR before merging PR into main.

I only refactored the inline style in FlatList by moving it into the StyleSheet as listContainer and applied it using contentContainerStyle. There are no other functional or UI changes.

@TeddyScript101
Copy link
Copy Markdown
Collaborator

Please only include changes related to refactoring inline styles in TimeSheetsScreen; other functional/UI changes should be removed or moved to a separate PR before merging PR into main.

I only refactored the inline style in FlatList by moving it into the StyleSheet as listContainer and applied it using contentContainerStyle. There are no other functional or UI changes.

However, I noticed that the Hours section and the UI component have been updated to use TouchableOpacity. Could you please confirm if those changes was part of another task? Just want to make sure we’re aligned on the scope of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants