Enhance POST /api/v1/shifts with site, guard, availability and clash validation#256
Open
Enhance POST /api/v1/shifts with site, guard, availability and clash validation#256
Conversation
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.









Summary
This PR enhances
POST /api/v1/shiftsto support the extended create-shift payload and backend validation required for employer shift creation.Changes made
extended
Shiftschema to support:shiftTypebreakTimedetailedInstructionsguardIdssiteIdlocation.latitudelocation.longitudeupdated
createShiftto:location,payRate,shiftType, andsiteIdguardIdsformat and ensure selected IDs belong to active guardssiteIdownership against employer branchesacceptedByapplicantsguardIdsupdated route auth behavior for
/api/v1/shiftsso:401403updated Swagger documentation for
POST /api/v1/shiftsto reflect the enhanced request body and response behaviorManual testing completed
201with valid employer token, valid branch/site, and valid payload400whenguardIdscontains invalid ObjectId values400whenguardIdscontains non-guard user IDs400when selected guard is unavailable on the requested weekday400when selected guard is unavailable for the requested time slot400when selected guard has a conflicting shift201when selected guard is available and the shift does not overlap an existing oneNotes