Show MMS subject in tap to download message#197
Merged
Conversation
m4pl
commented
Jul 11, 2026
m4pl
commented
Contributor
inthewaves
suggested changes
Jul 11, 2026
Comment on lines
+421
to
+428
| @Composable | ||
| private fun ConversationMessageSubject( | ||
| subjectText: String?, | ||
| modifier: Modifier = Modifier, | ||
| ) { | ||
| if (subjectText == null) { | ||
| return | ||
| } |
Member
There was a problem hiding this comment.
subjectText could also be blank too; https://github.com/GrapheneOS/Messaging/blob/main/src/com/android/messaging/sms/MmsSubjectSanitizer.kt doesn't clean blanks (it probably should)
m4pl
force-pushed
the
task/171-download-mms-subject
branch
from
8e0ceba to
9d71458
Compare
inthewaves
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.