Go member calls resolve to nothing across files, and cannot cross a repo boundary at all #3393

Activity

1. xiongjianxu commented on Sep 22, 2026

   

   xiongjianxu

   on Sep 22, 2026

   ContributorAuthor

   More actions

   Here is a self-contained, runnable reproduction (no module/toolchain setup — just graphify on PYTHONPATH). It covers both halves: the cross-file gap in a single repo and the cross-repo gap after merge-graphs.

   # repro_3393.py  —  python repro_3393.py   (exit 0 = fixed, 1 = bug present)
   import json, subprocess, sys, tempfile
   from pathlib import Path
   from graphify.extract import extract
   
   APP_GO = ("package svc\n\ntype App struct {\n\tgreeter *Greeter\n}\n\n"
             "func (a *App) Run() {\n\ta.greeter.Greet()\n}\n")
   GREETER_GO = "package svc\n\ntype Greeter struct{}\n\nfunc (g *Greeter) Greet() {}\n"
   
   def _extract(root):
       return extract(sorted(root.rglob("*.go")), cache_root=root / "graphify-out")
   
   def _calls(res):
       nodes = {n["id"]: n for n in res["nodes"]}
       return [(nodes[e["source"]]["label"], nodes[e["target"]]["label"])
               for e in res["edges"] if e.get("relation") == "calls"]
   
   def _write(path, res):
       path.parent.mkdir(parents=True, exist_ok=True)
       path.write_text(json.dumps({"directed": False, "multigraph": False, "graph": {},
                                   "nodes": res["nodes"], "links": res["edges"]}))
   
   def main():
       with tempfile.TemporaryDirectory() as d:
           tmp = Path(d)
           # A. cross-file, one repo
           (tmp / "single/svc").mkdir(parents=True)
           (tmp / "single/svc/app.go").write_text(APP_GO)
           (tmp / "single/svc/greeter.go").write_text(GREETER_GO)
           calls = _calls(_extract(tmp / "single"))
           a = any("Run" in s and "Greet" in t for s, t in calls)
           print("[A] cross-file calls edges:", calls or "(none)")
   
           # B. cross-repo, merge-graphs
           (tmp / "app/svc").mkdir(parents=True); (tmp / "lib/svc").mkdir(parents=True)
           (tmp / "app/svc/app.go").write_text(APP_GO)
           (tmp / "lib/svc/greeter.go").write_text(GREETER_GO)
           ag, bg = tmp / "app/graphify-out/graph.json", tmp / "lib/graphify-out/graph.json"
           _write(ag, _extract(tmp / "app")); _write(bg, _extract(tmp / "lib"))
           parked = [e for n in json.loads(ag.read_text())["nodes"]
                     if isinstance(n.get("metadata"), dict)
                     for e in n["metadata"].get("unresolved_calls", [])]
           print("[B] parked unresolved_calls:", parked or "(none)")
           out = tmp / "merged.json"
           subprocess.run([sys.executable, "-m", "graphify", "merge-graphs",
                           str(ag), str(bg), "--out", str(out)], cwd=tmp, check=True)
           xr = [(e["source"], e["target"]) for e in json.loads(out.read_text())["links"]
                 if e.get("relation") == "calls" and e.get("context") == "cross_repo"]
           print("[B] cross_repo calls edges:", xr or "(none)")
           return 0 if (a and xr) else 1
   
   sys.exit(main())

   On pristine v8 (20a20d3):

   [A] cross-file calls edges: (none)
   [B] parked unresolved_calls: (none)
   [B] cross_repo calls edges: (none)
   RESULT: cross-file = False  cross-repo = False   (exit 1)
   

   The a.greeter.Greet() call (receiver is a struct field of type *Greeter) produces no calls edge even when Greeter is declared in a sibling file, and nothing is parked, so merge-graphs cannot recover it across repos either — exactly the two shapes described above.

   With PR #3395 (feat/go-cross-repo-member-calls):

   [A] cross-file calls edges: [('.Run()', '.Greet()')]
   [B] parked unresolved_calls: [{'callee': 'Greet', 'receiver_type': 'Greeter', 'lang': 'go', 'line': 'L8'}]
   [B] cross_repo calls edges: [('app::svc_app_run', 'lib::svc_greeter_greet')]
   RESULT: cross-file = True  cross-repo = True   (exit 0)
   

   Cross-file is resolved directly; cross-repo is parked by name (no node ids, per the #3152 contract) and finished as an INFERRED / context=cross_repo edge by link_cross_repo_member_calls.

   PR #3395 cherry-picks clean onto the current v8 tip 20a20d3 (git merge-tree reports no conflicts; PR is MERGEABLE / CLEAN), so it can be picked up as-is or rebased on request.
2. safishamsi commented on Oct 13, 2026

   

   safishamsi

   on Oct 13, 2026

   Member

   More actions

   Fixed in v0.9.89 (graphifyy 0.9.89 on PyPI) via #3395.
3. safishamsi

   closed this as completedon Oct 13, 2026