Repository navigation
Conversation
Keep unresolved import paths through ID canonicalization, then remove the source_file claim without changing IDs, import edges, or specifier labels. Cover five syntax families, real-file resolution and retained AST caches. Co-Authored-By: Codex <noreply@openai.com>
|
Thanks for the pull request, @rileydev. A maintainer will review it soon. Want to talk it through while it is in review? Come join us on our Discord server. For longer-form discussion there is also GitHub Discussions. A couple of things that speed up review: make sure the test suite passes on Python 3.10 and 3.13, and that the change keeps extraction deterministic. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(extract): keep unresolved rescued imports free of false file provenance
Regex-rescued imports can emit unresolved package names, missing relative files, and browser import URLs as node
source_filevalues. Downstream consumers then treat references such asunknown-packageor/node_modules/.vite/deps/react.jsas real source files.Mark only stubs emitted by the unresolved-target branch and clear their file claim after the existing ID canonicalization pass. Keep the specifier label and importing-file edge evidence. Delaying the clearing preserves portable IDs for unresolved relative imports; the existing Astro portability regression remains unchanged.
Validation: 86 focused tests and five language subcases pass, including JS, TS, Svelte, Astro, Vue, resolved local imports, portable IDs and warm AST cache reuse. The new regression fails before the repair. Isolated full-corpus CLI builds on 0.9.49 and 0.9.77 pass cold and retained source-path validation and querying while preserving every node ID and edge. Installed runtimes were not modified. Full upstream validation also ran in a disposable, credential-free environment:
uv run --frozen --no-sync pytest tests/ -qreported 6,439 passed, 44 failed, 106 skipped and 5 subtests passed. The same 44 failures reproduced on the unchanged base: missing optional parser/OpenAI dependencies, absent historical Git objects in the source archive, and temporary-path assumptions.uv run --frozen --no-sync ruff check . --no-cachepassed.uv run --frozen --no-sync pyrightreported the same 637 errors and 4 warnings on candidate and base, with no added diagnostics. Full pytest and Pyright are not green; this PR remains a draft. The existing version-based AST cache namespace must advance with the upstream release; this is not a same-version hot patch.Prepared with OpenAI Codex. No private repository contents or credentials are included in this patch.